chore: update data_substrate for brpc eventfd wakeup - #487
chore: update data_substrate for brpc eventfd wakeup#487thweetkomputer wants to merge 8 commits into
Conversation
WalkthroughThe PR updates the data substrate submodule reference and enables IO_uring in the generated ChangesData substrate runtime update
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/mongo/db/modules/eloq/data_substrate`:
- Line 1: Update the Data Substrate gitlink to revision
39171c94549baf6d092ed4d24504fb94afd62785 instead of
a7fe637cbed6ca151b9145f906757d980902a3b1, preserving the module path and gitlink
structure.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6110aa06-57c4-4736-b04f-5dd1c2be40a0
📒 Files selected for processing (1)
src/mongo/db/modules/eloq/data_substrate
| @@ -1 +1 @@ | |||
| Subproject commit 63db0ecbe3cd04e23282aa61af3961491647bddf | |||
| Subproject commit 39171c94549baf6d092ed4d24504fb94afd62785 | |||
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
path='src/mongo/db/modules/eloq/data_substrate'
expected='a7fe637cbed6ca151b9145f906757d980902a3b1'
actual="$(git ls-tree HEAD -- "$path" | awk 'NF >= 3 {print $3}')"
if [[ "$actual" != "$expected" ]]; then
printf 'Expected %s at %s, found %s\n' "$expected" "$path" "$actual" >&2
exit 1
fi
git diff --submodule=log HEAD^ HEAD -- "$path"Repository: eloqdata/eloqdoc
Length of output: 296
🏁 Script executed:
#!/bin/bash
set -euo pipefail
path='src/mongo/db/modules/eloq/data_substrate'
actual="$(git ls-tree HEAD -- "$path" | awk 'NF >= 3 {print $3}')"
actual_prev="$(git ls-tree HEAD^ -- "$path" 2>/dev/null | awk 'NF >= 3 {print $3}' || true)"
expected='a7fe637cbed6ca151b9145f906757d980902a3b1'
printf 'HEAD submodule: %s\n' "$actual"
if [[ -n "$actual_prev" ]]; then
printf 'HEAD^ submodule: %s\n' "$actual_prev"
fi
printf 'Match expected: %s\n' "$([ "$actual" = "$expected" ] && echo yes || echo no)"
git diff --submodule=log HEAD^ HEAD -- "$path" || trueRepository: eloqdata/eloqdoc
Length of output: 381
Point the Data Substrate gitlink to the required revision.
This module points to 39171c94549baf6d092ed4d24504fb94afd62785, not a7fe637cbed6ca151b9145f906757d980902a3b1. If the target revision is needed for io_uring support, update the gitlink so this change builds against the intended Data Substrate code.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/mongo/db/modules/eloq/data_substrate` at line 1, Update the Data
Substrate gitlink to revision 39171c94549baf6d092ed4d24504fb94afd62785 instead
of a7fe637cbed6ca151b9145f906757d980902a3b1, preserving the module path and
gitlink structure.
Context
Exercise the eventfd worker-wakeup support merged in eloqdata/brpc#25 in EloqDoc CI, through eloqdata/tx_service#540.
EloqDoc compiled brpc with io_uring support, but its generated Data Substrate test configuration did not enable io_uring at runtime.
Changes
src/mongo/db/modules/eloq/data_substratetoa7fe637cbed6ca151b9145f906757d980902a3b1.masteratc12822d4931a59a9c2cc42df061975e114e93590.enable_io_uring=truein the Data Substrate configuration generated by EloqDoc CI.Product source code, document formats, query behavior, and packaged user configuration are unchanged; the runtime setting change is confined to CI.
Validation
The full EloqDoc build and integration suites are running in this PR's CI; they were not rerun locally for this dependency update.
Risk and rollback
The CI configuration requires a kernel supporting
DEFER_TASKRUNand multishot poll. Potential regressions include startup failures, missed wakeups, or shutdown hangs. Revert this PR to restore the previous Data Substrate pointer and CI runtime setting.Reviewer guide
Review
.github/scripts/common.shfor the CI-only runtime toggle and verify Data Substrate ata7fe637cbed6ca151b9145f906757d980902a3b1, which pins brpcmasteratc12822d4931a59a9c2cc42df061975e114e93590.Summary by CodeRabbit
New Features
Maintenance