[8.19] fix: bypass expired Debian 11 security repo in Dockerfile.build - #7783
Closed
ycombinator wants to merge 1 commit into
Closed
[8.19] fix: bypass expired Debian 11 security repo in Dockerfile.build#7783ycombinator wants to merge 1 commit into
ycombinator wants to merge 1 commit into
Conversation
Temporary workaround for Buildkite package build failures caused by the Debian 11 (Bullseye) security repository's InRelease file expiring after EOL. Passing -o Acquire::Check-Valid-Until=false to apt-get bypasses the expiry check so the Docker build can proceed. Root cause fix is upstream in golang-crossbuild: elastic/golang-crossbuild#754 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ycombinator
requested review from
lorienhu and
swiatekm
and
a lite review from Copilot
and removed request for
a team
September 8, 2026 16:54
Contributor
Author
|
Closing in favor of backporting #7782 (the main-branch counterpart) to 8.19 once it merges. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, targeted build-unblocker with only minor follow-up suggestions noted inline.
Pull request overview
This PR unblocks 8.19 branch package builds by working around Debian 11 (Bullseye) security repository metadata expiry in the golang-crossbuild base image, allowing apt-get update to succeed until the upstream base image is updated.
Changes:
- Add a temporary
apt-getoption (Acquire::Check-Valid-Until=false) duringapt-get updateto bypass the expiredValid-Untilcheck. - Document the workaround inline in
Dockerfile.buildto clarify intent and expected revert timing.
File summaries
| File | Description |
|---|---|
| Dockerfile.build | Temporarily bypasses Debian 11 repo metadata expiry during apt-get update to unblock build pipelines. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+5
to
+7
| # TEMPORARY: Debian 11 (Bullseye) reached EOL and its security repo InRelease | ||
| # has expired. Check-Valid-Until=false bypasses the expiry check so the build | ||
| # can proceed. Revert once golang-crossbuild base image is updated. |
| apt-get update \ | ||
| apt-get -o Acquire::Check-Valid-Until=false update \ | ||
| && apt-get install --no-install-recommends -y zip \ | ||
| && apt-get clean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InReleasefile has expired, causing all Buildkite package builds for the8.19branch to fail at theapt-get updatestep.-o Acquire::Check-Valid-Until=falsetoapt-getas a temporary workaround to bypass the expiry check.Impact
Without this fix, all open PRs against
8.19fail Buildkite — including unrelated updatecli bumps like #7780.Test plan
🤖 Generated with Claude Code