Skip to content

Remove legacy PR Buildkite Detective workflow - #7776

Merged
fr4nc1sc0-r4m0n merged 3 commits into
mainfrom
chore/migrate-estc-pr-buildkite-detective-to-obs-aw
Sep 17, 2026
Merged

fr4nc1sc0-r4m0n merged 3 commits into
mainfrom
chore/migrate-estc-pr-buildkite-detective-to-obs-aw

Conversation

@fr4nc1sc0-r4m0n

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Merge gate

Do not merge this PR until the oblt-aw distribution process has opened and merged the install PR that adds trigger-obs-aw-*.yml (especially trigger-obs-aw-status.yml) to this repository. Merging the legacy removal first would leave Buildkite status failures without a detective entrypoint.

Notes

  • After distribution and dashboard sync, enable obs:estc-pr-buildkite-detective on the [oblt-aw] Control Plane Dashboard issue (default is off).
  • Requires repository secret BUILDKITE_LOGS_API_TOKEN (already used by the legacy workflow where present).

Test plan

  • Confirm trigger-obs-aw-status.yml is present via distribute-client-workflow
  • Confirm legacy detective workflow file is gone
  • Confirm Control Plane Dashboard lists PR Buildkite Detective and enable it
  • On a failed Buildkite status for an open PR, confirm detective comment posts via the obs-aw route

Install trigger-obs-aw client workflows from elastic/oblt-aw and remove the legacy direct lock invocation for gh-aw-estc-pr-buildkite-detective.
Copilot AI lite review requested due to automatic review settings September 7, 2026 10:19
@fr4nc1sc0-r4m0n
fr4nc1sc0-r4m0n requested a review from a team as a code owner September 7, 2026 10:19
@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n self-assigned this Sep 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new reusable-workflow references are pinned to the mutable @main ref and explicitly exclude pinning (ratchet:exclude), creating an avoidable supply-chain and auditability risk for CI automation.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR migrates the PR Buildkite Detective automation from a legacy direct workflow invocation to the Observability Agentic Workflow (obs-aw) “status” routing, aligning Fleet Server’s GitHub Automation entrypoints with the shared control-plane driven workflow orchestration model.

Changes:

  • Removed the legacy PR Buildkite Detective status-triggered workflow that directly invoked gh-aw-estc-pr-buildkite-detective.lock.yml.
  • Added obs-aw trigger entrypoints for status, schedule, pull_request, issues, and issue_comment events that delegate to reusable workflows in elastic/oblt-aw.
  • Wired the Buildkite failure status path to pass BUILDKITE_LOGS_API_TOKEN as BUILDKITE_API_TOKEN into the obs-aw status reusable workflow.
File summaries
File Description
.github/workflows/trigger-pr-buildkite-detective.yml Removed legacy Buildkite detective workflow entrypoint.
.github/workflows/trigger-obs-aw-status.yml Added status-trigger entrypoint delegating Buildkite-failure routing to obs-aw.
.github/workflows/trigger-obs-aw-schedule.yml Added scheduled/dispatch entrypoint for obs-aw orchestration.
.github/workflows/trigger-obs-aw-pull-request.yml Added pull request event entrypoint for obs-aw orchestration.
.github/workflows/trigger-obs-aw-issues.yml Added issues/dispatch entrypoint for obs-aw orchestration.
.github/workflows/trigger-obs-aw-issue-comment.yml Added issue comment entrypoint for obs-aw orchestration.
Review details
  • Files reviewed: 6/6 changed files
  • Comments generated: 5
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/trigger-obs-aw-issue-comment.yml Outdated
Comment thread .github/workflows/trigger-obs-aw-issues.yml Outdated
Comment thread .github/workflows/trigger-obs-aw-pull-request.yml Outdated
Comment thread .github/workflows/trigger-obs-aw-schedule.yml Outdated
Comment thread .github/workflows/trigger-obs-aw-status.yml Outdated
@mergify

mergify Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

This pull request does not have a backport label. Could you fix it @fr4nc1sc0-r4m0n? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

Drop the previously added trigger-obs-aw client templates; distribute-client-workflow will install those after control-plane registration merges.
Copilot AI review requested due to automatic review settings September 7, 2026 11:37
@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n changed the title Migrate PR Buildkite Detective onto obs-aw status route Remove legacy PR Buildkite Detective workflow Sep 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The legacy detective trigger is removed but no replacement trigger-obs-aw-* workflow exists in this repo today, so merging can interrupt detective coverage unless the external distribution prerequisite is already in place.

Review details

Suppressed comments (1)

.github/workflows/trigger-pr-buildkite-detective.yml:1

  • This change deletes PR Buildkite Detective entirely, and there is currently no replacement trigger-obs-aw-* workflow in this repo; merging as-is will disable detective coverage until the external distribute-client-workflow PRs land. Consider adding the replacement trigger workflow in this PR (or as a prerequisite PR) to avoid an interruption in triage automation.
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings September 16, 2026 17:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The replacement status listener must be installed before removing the legacy workflow.

Review details

Suppressed comments (1)

.github/workflows/trigger-pr-buildkite-detective.yml:1

  • Merging this deletion before the distribute-client-workflow install PR lands removes the only status listener for Buildkite failures; this checkout has no trigger-obs-aw-*.yml replacement, so failed Buildkite statuses will no longer invoke the detective. Please defer this removal until trigger-obs-aw-status.yml is present in the repository (as required by the PR description), or include the replacement workflow in the same change.
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@mergify

mergify Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@fr4nc1sc0-r4m0n
fr4nc1sc0-r4m0n merged commit a9a99c3 into main Sep 17, 2026
13 checks passed
@fr4nc1sc0-r4m0n
fr4nc1sc0-r4m0n deleted the chore/migrate-estc-pr-buildkite-detective-to-obs-aw branch September 17, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants