[8.19](backport #7919) [Asset Inventory][EC2] Add timeout handler to IAM resolver - #7922
Open
mergify[bot] wants to merge 1 commit into
Open
[8.19](backport #7919) [Asset Inventory][EC2] Add timeout handler to IAM resolver#7922mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
### Summary of your changes Add 10s timeout to `GetInstanceProfile` calls in EC2 instance fetcher The IAM client uses the default HTTP transport with no timeout. If `GetInstanceProfile` hangs, the fetch loop blocks before sending any asset to the channel, so zero EC2 assets are published. Errors are already handled gracefully (falls back to the profile ARN), so a timeout is enough to resolve any issues. ### Related Issues Resolves error for integration tests. (cherry picked from commit e1ea204) # Conflicts: # internal/inventory/awsfetcher/fetcher_ec2_instance.go
Contributor
Author
|
Cherry-pick of e1ea204 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @kubasobon? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of your changes
Add 10s timeout to
GetInstanceProfilecalls in EC2 instance fetcherThe IAM client uses the default HTTP transport with no timeout. If
GetInstanceProfilehangs, the fetch loop blocks before sending any asset to the channel, so zero EC2 assets are published. Errors are already handled gracefully (falls back to the profile ARN), so a timeout is enough to resolve any issues.Related Issues
Resolves error for integration tests.
This is an automatic backport of pull request #7919 done by [Mergify](https://mergify.com).