Skip to content

Fixed a kernel stack leak when deleting user-mode module threads #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fdesbiens merged 2 commits into from
Sep 8, 2026
+26 −6
Merged

Fixed a kernel stack leak when deleting user-mode module threads #692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f24633
modules: free kernel stack on thread deletion
prashit-vora Aug 31, 2026
302fd2d
Preserved the thread object release when the kernel stack cannot be f…
fdesbiens Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions common_modules/module_manager/inc/txm_module_manager_dispatch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
*
* SPDX-License-Identifier: MIT
**************************************************************************/
// Some portions generated by Codex (GPT-5).
// Some portions generated by Copilot (Opus 5).


/**************************************************************************/
Expand Down Expand Up @@ -2061,22 +2063,40 @@ ALIGN_TYPE return_value;
static ALIGN_TYPE _txm_module_manager_tx_thread_delete_dispatch(TXM_MODULE_INSTANCE *module_instance, ALIGN_TYPE param_0)
{

ALIGN_TYPE return_value;
TX_THREAD *thread_ptr;
ALIGN_TYPE return_value;
ALIGN_TYPE stack_status;

thread_ptr = (TX_THREAD *) param_0;
stack_status = (ALIGN_TYPE) TX_SUCCESS;

if (module_instance -> txm_module_instance_property_flags & TXM_MODULE_MEMORY_PROTECTION)
{
if (!TXM_MODULE_MANAGER_PARAM_CHECK_OBJECT_FOR_USE(module_instance, param_0, sizeof(TX_THREAD)))
return(TXM_MODULE_INVALID_MEMORY);
}

return_value = (ALIGN_TYPE) _txe_thread_delete(
(TX_THREAD *) param_0
);
return_value = (ALIGN_TYPE) _txe_thread_delete(thread_ptr);

/* Deallocate object memory. */
/* Deallocate the kernel stack for a user-mode thread. */
if ((return_value == TX_SUCCESS) &&
(module_instance -> txm_module_instance_property_flags & TXM_MODULE_USER_MODE))
{
stack_status = _txm_module_manager_object_deallocate(thread_ptr -> tx_thread_module_kernel_stack_start);
}

/* Deallocate thread object memory. This must be attempted even when the kernel
stack could not be released, otherwise a successful thread delete would leave
the thread object allocated forever. */
if (return_value == TX_SUCCESS)
{
return_value = _txm_module_manager_object_deallocate((VOID *) param_0);
return_value = _txm_module_manager_object_deallocate((VOID *) thread_ptr);

/* Report the kernel stack failure if the thread object was released. */
if ((return_value == TX_SUCCESS) && (stack_status != TX_SUCCESS))
{
return_value = stack_status;
}
}
return(return_value);
}
Expand Down