Skip to content

Allow customizing CommonTab#2676

Merged
iloveeclipse merged 2 commits into
eclipse-platform:masterfrom
trancexpress:gh2675
Jun 1, 2026
Merged

Allow customizing CommonTab#2676
iloveeclipse merged 2 commits into
eclipse-platform:masterfrom
trancexpress:gh2675

Conversation

@trancexpress
Copy link
Copy Markdown
Contributor

Open up CommonTab for overriding methods, to customize what elements are shown in the UI. This allows to e.g. hide common tab elements that are not relevant for custom launch types.

Fixes: #2675

@trancexpress trancexpress requested a review from iloveeclipse May 26, 2026 16:21
Comment thread debug/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/CommonTab.java Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026

Test Results

    54 files  ±0      54 suites  ±0   35m 39s ⏱️ -48s
 4 667 tests ±0   4 645 ✅ ±0   22 💤 ±0  0 ❌ ±0 
11 895 runs  ±0  11 742 ✅ ±0  153 💤 ±0  0 ❌ ±0 

Results for commit 40a5216. ± Comparison against base commit b12e26a.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 82b20f59a25d65b20a5fc556eb9f6a140449e4f2 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Mon, 1 Jun 2026 08:03:29 +0000
Subject: [PATCH] Version bump(s) for 4.41 stream


diff --git a/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF b/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
index 8c8a0b29b7..489122e563 100644
--- a/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.debug.ui; singleton:=true
-Bundle-Version: 3.21.0.qualifier
+Bundle-Version: 3.21.100.qualifier
 Bundle-Activator: org.eclipse.debug.internal.ui.DebugUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Copy Markdown
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except bundle version bump.

Comment thread debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF Outdated
Comment thread debug/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/CommonTab.java Outdated
@iloveeclipse
Copy link
Copy Markdown
Member

@trancexpress : please use "since 3.22" now everywhere in this PR, "since 3.21" makes no sense.

@iloveeclipse iloveeclipse marked this pull request as ready for review June 1, 2026 10:00
Copy link
Copy Markdown
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please resolve merge conflicts with manifest version.

Open up CommonTab for overriding methods, to customize what elements are shown in the UI.
This allows to e.g. hide common tab elements that are not relevant for custom launch types.

Fixes: eclipse-platform#2675
@iloveeclipse iloveeclipse merged commit 5881361 into eclipse-platform:master Jun 1, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow customizing CommonTab

4 participants