Fix warnings in jface.text.tests#4062
Merged
Merged
Conversation
Had to add forRemoval=true to DefaultUndoManager constructor as this is not inherited from the class. Removed some useless comments and added more Deprecated to tests implementation to get the bundle clean.
Member
Author
|
Initiated by the o.e.jface.text.tests bundle being reported as only qualifier bump in https://download.eclipse.org/eclipse/downloads/drops4/I20260603-1800/buildlogs/reporeports/reports/versionChecks.html |
Contributor
Test Results 861 files ±0 861 suites ±0 59m 38s ⏱️ + 6m 59s For more details on these failures, see this check. Results for commit e2cddaf. ± Comparison against base commit d4ec601. ♻️ This comment has been updated with latest results. |
Stuck on JUnit 3 and totally not working without anyone noticing. It's far too easier to just Run As project/folder/package/class that this launch config is totally useless.
Member
Author
|
8 warnings less. Test failures are unrelated. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had to add forRemoval=true to DefaultUndoManager constructor as this is not inherited from the class.
Removed some useless comments and added more Deprecated to tests implementation to get the bundle clean.