Update WorkbenchActionBuilder to use IEclipsePreferences#4061
Open
deepika-u wants to merge 1 commit into
Open
Conversation
Contributor
deepika-u
force-pushed
the
use_ieclipsepreferences_instead
branch
from
e287fab to
d1adb7a
Compare
Contributor
Author
|
@HeikoKlare |
HeikoKlare
reviewed
Jun 6, 2026
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Thank you for this enhancement. The change looks reasonable to me.
Just as a minor comment: the change regarding usage of CommandContributionItemParameter seems unrelated to preferences. It would be cleaner to have that in a separate commit/PR to stay at one concern per commit (or otherwise at least explain that change in the commit message and PR as well).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IEclipsePreferences is used to modernize WorkbenchActionBuilder by updating references of org.eclipse.core.runtime.Preferences.
Partially fixes
eclipse-platform/eclipse.platform#497