Update Show In MRU when triggered from Open Resource dialog#4059
Merged
Conversation
Contributor
Using Show In from the Open Resource dialog, either via the dropdown or the implicit action on a non-file selection, opened the target view but never updated the most-recently-used order. Both paths call showView and IShowInTarget.show directly instead of the Navigate > Show In command, so WorkbenchPage.performedShowIn was never invoked and the MRU list stayed unchanged. Promote the used target via performedShowIn after a successful show, so the Open Resource dialog feeds the same MRU as the regular Show In. Fixes eclipse-platform#4058
vogella
force-pushed
the
open-resource-showin-mru
branch
from
b638b63 to
439bbc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Open Resource dialog drives Show In through its own actions (both the dropdown and the implicit action on a non-file selection), calling showView and IShowInTarget.show directly rather than the Navigate > Show In command. As a result WorkbenchPage.performedShowIn was never called and the most-recently-used order of Show In targets was left untouched, unlike the regular Show In popup.
This promotes the used target via performedShowIn after a successful show, so launching Show In from Open Resource feeds the same MRU list as the standard command.
Fixes #4058