Skip to content

feat: add core-js check#182

Merged
43081j merged 25 commits into
e18e:mainfrom
AlexanderKaran:core-js
May 10, 2026
Merged

feat: add core-js check#182
43081j merged 25 commits into
e18e:mainfrom
AlexanderKaran:core-js

Conversation

@AlexanderKaran
Copy link
Copy Markdown
Contributor

Moved my hacky version of detecting CoreJS into the CLI. Will only check build folder if you pass in a flag for now. Example output from testing a package from the framework tracker:

⏺ {
    "stats": {
      "name": "starter-next-js",
      "version": "0.1.0",
      "dependencyCount": {
        "production": 3,
        "development": 6
      },
      "extraStats": [
        {
          "name": "duplicateDependencyCount",
          "value": 12,
          "label": "Duplicate Dependency Count"
        },
        {
          "name": "vendoredPolyfillSize",
          "label": "Vendored Polyfill Size",
          "value": 112594
        }
      ],
      "installSize": 623096777
    },
    "messages": [
      {
        "severity": "suggestion",
        "score": 0,
        "message": "The package does not specify the \"type\" field. Node.js may attempt to detect the package type causing a small performance hit. Consider adding \"type\": \"commonjs\"."
      },
      ... (12 duplicate dependency warnings) ...
      {
        "severity": "warning",
        "score": 0,
        "message": "Vendored core-js 3.38.1 detected in .next/static/chunks/a6dad97d9634a72d.js (110.0 KB). This bundle includes 534 polyfills, of which 255 are unnecessary for modern browsers. Consider using a targeted polyfill
  strategy or removing core-js from your build."
      }
    ]
  }

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 7, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@e18e/cli@182

commit: ce2a5ff

Copy link
Copy Markdown
Collaborator

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job @AlexanderKaran 😄 left a few comments

Comment thread src/analyze/core-js.ts Outdated
Comment thread src/analyze/core-js.ts Outdated
Comment thread src/analyze/core-js.ts Outdated
Comment thread src/analyze/core-js.ts Outdated
@dreyfus92 dreyfus92 changed the title Core JS feat: add build-dir flag Mar 7, 2026
@dreyfus92
Copy link
Copy Markdown
Collaborator

dreyfus92 commented Mar 7, 2026

cc. @43081j 👀

AlexanderKaran and others added 5 commits March 7, 2026 12:12
Co-authored-by: paul valladares <85648028+dreyfus92@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Alex 😄

Comment thread src/analyze/core-js.ts Outdated
@AlexanderKaran AlexanderKaran changed the title feat: add build-dir flag feat: add core-js check Mar 17, 2026
Comment thread src/analyze/core-js.ts Outdated
Comment thread src/analyze/core-js.ts
@43081j
Copy link
Copy Markdown
Contributor

43081j commented Mar 18, 2026

super nice! just a couple of comments

mostly we should decide if src is a list of directories, or a list of globs

@AlexanderKaran
Copy link
Copy Markdown
Contributor Author

super nice! just a couple of comments

mostly we should decide if src is a list of directories, or a list of globs

Great @dreyfus92 what are your thoughts?

Copy link
Copy Markdown
Collaborator

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @AlexanderKaran awesome job, left you a few comments 😄

Comment thread src/analyze/core-js.ts Outdated
Comment thread src/analyze/core-js.ts
Comment thread src/analyze/core-js.ts Outdated
@AlexanderKaran
Copy link
Copy Markdown
Contributor Author

super nice! just a couple of comments

mostly we should decide if src is a list of directories, or a list of globs

Done

@AlexanderKaran
Copy link
Copy Markdown
Contributor Author

@dreyfus92 @43081j Pushed a few updates and replied about the es-module-lexer vs require

Copy link
Copy Markdown
Collaborator

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✌🏻

Comment thread src/analyze/core-js.ts Outdated
@43081j 43081j merged commit 8d27fb2 into e18e:main May 10, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants