feat: add core-js check#182
Merged
Merged
Conversation
commit: |
dreyfus92
reviewed
Mar 7, 2026
Collaborator
dreyfus92
left a comment
There was a problem hiding this comment.
awesome job @AlexanderKaran 😄 left a few comments
Collaborator
|
cc. @43081j 👀 |
Co-authored-by: paul valladares <85648028+dreyfus92@users.noreply.github.com>
43081j
reviewed
Mar 7, 2026
43081j
reviewed
Mar 18, 2026
43081j
reviewed
Mar 18, 2026
Contributor
|
super nice! just a couple of comments mostly we should decide if |
Contributor
Author
Great @dreyfus92 what are your thoughts? |
dreyfus92
reviewed
Mar 19, 2026
Collaborator
dreyfus92
left a comment
There was a problem hiding this comment.
hey @AlexanderKaran awesome job, left you a few comments 😄
Contributor
Author
Done |
Contributor
Author
|
@dreyfus92 @43081j Pushed a few updates and replied about the |
43081j
reviewed
Apr 4, 2026
43081j
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved my hacky version of detecting CoreJS into the CLI. Will only check build folder if you pass in a flag for now. Example output from testing a package from the framework tracker: