Repository navigation
Preserve instructions during FB static access conversion - #264
Merged
Merged
Conversation
Member
Author
|
@TomMuehlegger |
Contributor
|
@jogibear9988 the changes are looking good. I did a review and the behaviour should more or less stay the same. Good from our end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #247.
ReplaceStaticAccesscould drop everyLAR2, the indirect DI access afterTAR2/+AR2, and buffered instructions at the end of a block. Replace operands in place so every original instruction remains in order. Keep the existing ordinary symbolic replacement and MC7 bytes, and leave unsupported offset-based accesses unchanged. Remove the unused offset calculation, which could also throw for operandless+AR2.Validation: added 10 regression cases covering instruction preservation, ordinary symbolic replacement and MC7 preservation, disabled conversion, and non-FB blocks. The full unit test suite passes on the latest master: 61 passed, 0 failed (
dotnet test ToolBoxLibUnitTests/ToolBoxLibUnitTests.csproj).