Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Author
|
@dotnet-policy-service agree |
|
Commenter does not have sufficient privileges for PR 134277 in repo dotnet/runtime |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #134115
Description
Under the updated memory safety rules (
net11.0/ Roslyn preview diagnostics),src/tasks/AndroidAppBuilder/Templates/monodroid-nativeaot.csfailed to build for Android NativeAOT legs with:CS9377: The 'unsafe' modifier does not have any effect on type declarations (MonoDroidExports,JNIEnv,JNINativeInterface,JavaVM).CS9389: 'extern' member (AndroidCryptoNative_InitLibraryOnLoadandManagedMain) must be marked 'unsafe' or 'safe'.Changes
unsafemodifiers fromMonoDroidExports,JNIEnv,JNINativeInterface, andJavaVMtype declarations.unsafedirectly to pointer-bearing JNI entry points and methods (SetEnv,InitRuntime,ExecEntryPoint,FreeNativeResources,GetStringUTFChars,GetJavaVM,GetArrayLength,GetObjectArrayElement).AndroidCryptoNative_InitLibraryOnLoadandManagedMainasunsafe.Verification
LanguageVersion.Preview) with 0 diagnostics.unsafemodifier scoping across all affected declarations.