[release/11.0] Remove open delegate Equals fastpath - #134267
Merged
Merged
Conversation
The fastpath was not correct in face of virtual methods. Fixes #134218.
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
This was referenced Sep 19, 2026
steveisok
approved these changes
Sep 21, 2026
steveisok
enabled auto-merge (squash)
September 21, 2026 18:31
Member
|
/ba-g Known issues unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #134224 to release/11.0
/cc @jkotas @MichalPetryka
Customer Impact
Delegate.Equals returns true instead of false when the delegate targets are two different virtual methods that happen to point to the same slot.
Regression
Regression introduced by delegate performance improvements.
Testing
Regression test
Risk
Low