Skip to content

Clarify NegotiateAuthentication completion semantics - #134199

Open
MihaZupan with Copilot wants to merge 1 commit into
mainfrom
copilot/incorporate-docs-improvements
Open

MihaZupan with Copilot wants to merge 1 commit into
mainfrom
copilot/incorporate-docs-improvements

Conversation

Copilot AI commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Ports the documentation improvements from dotnet/dotnet-api-docs#12724 into NegotiateAuthentication XML comments so they appear in IntelliSense.

  • Clarifies that IsAuthenticated indicates exchange completion, not success.
  • Directs callers to the latest GetOutgoingBlob status code.
  • Removes the misleading IsAuthenticated reference from TargetName.

Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@MihaZupan
MihaZupan marked this pull request as ready for review September 18, 2026 14:48
Copilot AI lite review requested due to automatic review settings September 18, 2026 14:48
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @karelz, @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The ContinueNeeded status needs to be described as an in-progress exchange.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR updates NegotiateAuthentication XML documentation to clarify authentication completion and status semantics for IntelliSense.

Changes:

  • Clarifies IsAuthenticated behavior.
  • Directs callers to GetOutgoingBlob status codes.
  • Removes the misleading IsAuthenticated reference from TargetName.

The documentation should distinguish ContinueNeeded as an in-progress exchange rather than implying authentication failure.

File summaries
File Summary
src/libraries/System.Net.Security/src/System/Net/Security/NegotiateAuthentication.cs Updates public property documentation.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants