Conversation
Explain how Boolean filters and row-index collections select, order, and repeat rows and column values. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Some clone documentation contradicts sequence truncation and ignored append parameters.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Clarifies DataFrame row-selection, cloning, and row-subset computation semantics.
Changes:
- Documents Boolean and index-based row selection.
- Clarifies ordering, repeated indices, and cumulative-operation parameters.
- Updates generated documentation and its template.
| File | Description |
|---|---|
PrimitiveDataFrameColumn.cs |
Documents clone overload behavior. |
DataFrameColumns/VBufferDataFrameColumn.cs |
Inherits clone documentation. |
DataFrameColumns/StringDataFrameColumn.cs |
Inherits clone documentation. |
DataFrameColumns/ArrowStringDataFrameColumn.cs |
Inherits clone documentation. |
DataFrameColumn.cs |
Clarifies base clone contracts. |
DataFrameColumn.Computations.tt |
Updates computation documentation template. |
DataFrameColumn.Computations.cs |
Regenerates row-subset documentation. |
DataFrame.cs |
Clarifies filtering and indexer semantics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| return ret; | ||
| } | ||
|
|
||
| /// <inheritdoc cref="DataFrameColumn.Clone(DataFrameColumn, bool, long)"/> |
Comment on lines
+541
to
+546
| /// <summary> | ||
| /// Clones the column using the values in <paramref name="mapIndices"/> as zero-based indices into this column. | ||
| /// </summary> | ||
| /// <param name="mapIndices"> | ||
| /// The indices of values to copy. Their enumeration order determines the result order, and repeated indices produce repeated values. | ||
| /// </param> |
Member
Author
|
Closing as supeseded by #7753. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7750 +/- ##
==========================================
- Coverage 69.89% 69.89% -0.01%
==========================================
Files 1487 1487
Lines 276323 276323
Branches 28295 28295
==========================================
- Hits 193142 193133 -9
- Misses 75694 75699 +5
- Partials 7487 7491 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation