feat(visitor-plugin-common): Simpler and more readable output when using inlineFragmentTypes: combine (resolve #8320)#8321
Open
yusufkandemir wants to merge 7 commits into
Conversation
Also improved the comments and extracted to a method to increase clarity
After a bit of fiddling around I discovered that buildSelectionSet gets run for each possible type in union typed queries. This means each fragment will match the main type. So, we can simply check if there is at least one fragment.
I actually implemented the test cases earlier, but 🤷
|
yusufkandemir
changed the title
yusufkandemir
changed the title
Collaborator
|
can you please rebase and run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related #8320. See the issue for a detailed explanation.
Type of change
(One could say this is a bug fix and not a feature, depends on how you look at it)
Screenshots/Sandbox (if appropriate/relevant):
See #8320 for screenshots
How Has This Been Tested?
By updating and improving the existing test case for
inlineFragmentTypes: combine. There are basically 3 possible combinations:__typename__typenameis added__typenamefor types that are covered by a fragmentTest Environment:
Checklist:
Further comments
None.