-
Notifications
You must be signed in to change notification settings - Fork 394
feat: add session-scoped plan/build mode #3140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
trungutt
wants to merge
1
commit into
docker:main
Choose a base branch
from
trungutt:plan-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| package runtime | ||
|
|
||
| import ( | ||
| "github.com/docker/docker-agent/pkg/chat" | ||
| "github.com/docker/docker-agent/pkg/session" | ||
| ) | ||
|
|
||
| // planModeReminder is the per-turn system instruction injected when a session | ||
| // is in plan mode. Two layers enforce plan mode: the runtime hides every | ||
| // non-read-only tool from the model (see filterToolsForSession in loop.go), | ||
| // and this reminder tells the model how it should behave. Hiding the tools | ||
| // is the hard guarantee; the reminder is the explanation, so the model | ||
| // produces a useful plan instead of just bouncing off missing tools. | ||
| const planModeReminder = `<system-reminder> | ||
| You are currently in PLAN MODE. | ||
|
|
||
| In this mode you research the codebase, ask clarifying questions, and write a | ||
| clear, actionable plan for the user. You MUST NOT make any changes to the | ||
| system: | ||
|
|
||
| - No edits to files (no write, edit, create, or delete). | ||
| - No shell commands or background jobs. | ||
| - No state-changing tool calls of any kind. | ||
|
|
||
| Only read-only tools have been made available to you for this turn. If you try | ||
| to call a tool that isn't in your list, the user has explicitly disabled it | ||
| for planning. | ||
|
|
||
| End the turn by presenting the plan in your final message and asking the user | ||
| to review it. The user will switch you to BUILD MODE when they want execution | ||
| to begin. | ||
| </system-reminder>` | ||
|
|
||
| // planModeReminderMessages returns the system-reminder messages to splice | ||
| // before the conversation history when sess is in plan mode. Returns nil for | ||
| // other modes so callers can use it unconditionally. | ||
| func planModeReminderMessages(sess *session.Session) []chat.Message { | ||
| if sess == nil || sess.Mode != session.ModePlan { | ||
| return nil | ||
| } | ||
| return []chat.Message{{ | ||
| Role: chat.MessageRoleSystem, | ||
| Content: planModeReminder, | ||
| }} | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.