warn about deploy attributes ignored in standalone mode - #14192
Open
veerareddyvishal144 wants to merge 1 commit into
Open
warn about deploy attributes ignored in standalone mode#14192veerareddyvishal144 wants to merge 1 commit into
veerareddyvishal144 wants to merge 1 commit into
Conversation
Signed-off-by: vishal veerareddy <vishalveera.reddy@servicenow.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13150
Compose silently ignores several
deploysub-attributes outside Swarm mode (e.g. a service withdeploy.update_configbehaves as if it wasn't set). Per the Compose spec the runtime should warn about unsupported attributes.Change
cmd/compose/warnings.go: after the project model loads (ProjectOptions.ToProject), emit one warning per service listing the ignored deploy attributes it sets:placement.constraints,placement.preferences,update_config,rollback_config,endpoint_mode,mode. Attributes that are still honored (replicas, device reservations,restart_policyfallback) are deliberately excluded.Verification
go test ./cmd/compose/passes (incl. new tests);golangci-lint0 issues; gofmt clean.update_config+placement.constraintsprintsService "web" uses deploy attributes that are ignored by Compose in standalone mode: placement.constraints, update_configon stderr; a replicas-only service stays silent.