fix(build): don't fail bake progress when stdout is not a console - #14184
fix(build): don't fail bake progress when stdout is not a console#14184locker95 wants to merge 1 commit into
Conversation
docker#14090 hands the real stdout file to buildkit so Windows TTY progress works. that also passes a redirected stdout (`build >/dev/null`) into ConsoleFromFile, which errors with "provided file is not a console". only unwrap a terminal file, and fall back to plain progress otherwise. Fixes docker#14182 Signed-off-by: Dean Chen <862469039@qq.com>
|
Thanks for digging into #14182 — the analysis of the failure is right, but the fix lands in the wrong place, so we'll go with an alternative. The root cause is a mode/stream mismatch: Patching it in
#14194 fixes the root cause instead: pass the unresolved Closing in favor of #14194 — thanks again for the report and the repro. |
#14090 unwraps the real stdout file so Windows TTY progress works. that also feeds a redirected stdout (
compose build >/dev/null) into ConsoleFromFile, which then dies withprovided file is not a console.only unwrap when stdout actually is a terminal, and fall back to plain progress otherwise.
Fixes #14182