test(csp): also guard against trailing bare https: source#275
Open
dormouse-bot wants to merge 1 commit into
Open
test(csp): also guard against trailing bare https: source#275dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
Deploying mouseterm with
|
| Latest commit: |
835425c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d99ea8d6.mouseterm.pages.dev |
| Branch Preview URL: | https://test-csp-https-scheme-guard.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced by the nightly code-quality survey.
The "secure by default" CSP test asserts that
connect-srccarries no scheme-widehttps:/wss:source (which would let the webview reach an arbitrary internet host). Thewss:guard checks both placements — mid-directive (' wss: ') and end-of-directive (' wss:;') — but the parallelhttps:guard only checked the mid-directive form. A barehttps:;at the end of theconnect-srcdirective — exactly wherewss://*.dormouse.sh;currently sits — would have slipped through, contradicting the test's stated intent.This mirrors the
wss:guard onto thehttps:check so both scheme-wide forms are caught in either position.Test-only robustness fix — no product code changes. The existing four
csp.test.mjscases still pass (the shipped CSP has no barehttps:in either form); this closes the gap so a future regression that introduced a trailinghttps:;would be caught.