Skip to content

Install Rust with rustup directly instead of dtolnay/rust-toolchain #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nedtwigg merged 1 commit into from
Oct 9, 2026
Merged

Install Rust with rustup directly instead of dtolnay/rust-toolchain #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,13 @@ jobs:

- uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0

- uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # stable
# rustup ships on every GitHub-hosted runner, so no third-party action
# installs the toolchain: dtolnay/rust-toolchain force-pushes the branch
# its SHA pin points into on every upstream change, which turns the pin
# into an impostor commit for zizmor.
- name: Install Rust stable
shell: bash
run: rustup toolchain install stable --profile minimal --no-self-update && rustup default stable

- name: Install system dependencies
# apt mirrors are flaky: a healthy run finishes in <1min, but a degraded
Expand Down Expand Up @@ -349,7 +355,10 @@ jobs:
with:
node-version-file: package.json

- uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # stable
# Same direct rustup install as the smoketest above.
- name: Install Rust stable
shell: bash
run: rustup toolchain install stable --profile minimal --no-self-update && rustup default stable

# Windows and macOS runners bill at a multiple of Linux, so the dependency
# compile is cached rather than paid on every PR.
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,14 @@ jobs:
- name: Install workspace dependencies
run: pnpm install --frozen-lockfile

- uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # stable
with:
targets: ${{ matrix.target }}
# Direct rustup rather than an action; ci.yml's smoketest says why.
- name: Install Rust stable
shell: bash
run: |
rustup toolchain install stable --profile minimal --no-self-update --target "$TARGET"
rustup default stable
env:
TARGET: ${{ matrix.target }}

# No Rust cache: a release build restores nothing a run on another ref
# wrote, since the default branch's cache scope is reachable from every
Expand Down
Loading