Repository navigation
Repin dtolnay/rust-toolchain after its stable branch was force-pushed - #1088
Closed
dormouse-bot wants to merge 1 commit into
Closed
dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
Deploying mouseterm with
|
| Latest commit: |
520602d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://78e1c601.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-rust-toolchain-pin.mouseterm.pages.dev |
Member
|
Superseded by #1089, which drops dtolnay/rust-toolchain for direct rustup calls instead of re-pinning into a branch that upstream force-pushes on every change. |
nedtwigg
requested a deployment
to
hosted-preview
October 9, 2026 15:21 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every new PR's
Workflow Lintjob now fails, andmainwill fail it on its next push. This moves thedtolnay/rust-toolchainpin inci.yml(2 places) andrelease.yml(1 place) from89b12181to686976e1, the current tip of itsstablebranch.Why. At 02:03Z today, upstream force-pushed
stableto686976e1. The old pin89b12181is no longer in that branch's history; GitHub's compare API reports the two as diverged, 1 ahead and 4 behind. zizmor's online impostor-commit audit flags any pinned commit that no branch or tag of the referenced repo contains, so it reportsci.yml:263,ci.yml:352, andrelease.yml:59as errors. #1086 and #1087 failed on exactly those lines (e.g. run 37936709672), though neither PR touches a workflow file.main's last CI run, at 23:50Z yesterday, came before the force-push and passed.Renovate tracks this pin through the
# stablecomment, but its github-actions group only runs on Mondays, so PRs would stay red until then. The same failure can return whenever upstream rewritesstableagain; this PR does not change how the action is pinned.Age of the new commit.
686976e1is about 13 hours old. No configured cooldown covers action pins:docs/specs/security-supply-chain.md-> "Cooldown and alerts" gates npm, cargo, and the hand-installed zizmor and actionlint, and Renovate's github-actions rule sets nominimumReleaseAge. If you want the 1-day bar here anyway, it clears at 02:03Z on 10-10. The upstream change is dtolnay/rust-toolchain#187, "Safely handle action inputs":action.ymlmoves${{ }}interpolations out ofrun:scripts intoenv:and builds rustup flags as a bash array. It also makestoolchainoptional, defaulting tostable. None of that changes how our three call sites behave.The
Workflow Lintcheck on this PR verifies the fix.