#2219: Add UnpackCommandlet for extracting already supported archieve Formats - #2334
#2219: Add UnpackCommandlet for extracting already supported archieve Formats #2334majesteSil wants to merge 9 commits into
Conversation
…operties and Help_de.properties
…mmandlet' into feature/issue-2219-add-unpack-commandlet
Coverage Report for CI Build 32111757951Warning No base build found for commit Coverage: 72.932%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
There was a problem hiding this comment.
Great work on adding an unpack commandlet to IDEasy! I've tested the unpacking and it works, however the target parameter is not working. So I still have a few suggestions, mainly concerning the target parameter not working and wrong descriptions.
Also your commits have an inconsistent link to the issue (some falsely point to #2298). This should be fixed aswell.
There was a problem hiding this comment.
Add an E2E test for CLI parsing here.
There was a problem hiding this comment.
@samuelkos17 schaue bitte nochmal nach, ob es jetzt passend ist
…mmandlet' into feature/issue-2219-add-unpack-commandlet
…itional target argument
This PR fixes #2219
Adds a new "unpack" commandlet that extracts archive files into a target directory. The commandlet supports ZIP, TAR, TAR.GZ, TAR.BZ2, 7Z, JAR (cross-platform) and notes platform-specific formats like MSI/DMG/PKG. The commandlet is registered in the commandlet manager and covered by unit tests.
Implemented changes:
Testing instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc