Skip to content

#2293: rework spyder as ide tool commandlet - #2333

Draft
JoelAdbu wants to merge 11 commits into
devonfw:mainfrom
JoelAdbu:feature/2293-rework-spyder-as-ideToolCommandlet
Draft

#2293: rework spyder as ide tool commandlet#2333
JoelAdbu wants to merge 11 commits into
devonfw:mainfrom
JoelAdbu:feature/2293-rework-spyder-as-ideToolCommandlet

Conversation

@JoelAdbu

Copy link
Copy Markdown
Contributor

This PR fixes #2293

Implemented changes:


Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:


Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summaries what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
    with internal
  • You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

- extracted workspace Configuration logic and repository import into a new class IdeWorkspaceConfigurer
- added new  extensible interface IdeFeature so workspace configuration is not only available for IdeToolCommandlets but also for Ide's that extend different classes like PipBasedIdeToolCommandlet
- PipbasedIdeToolCommandlet implementes IdeFeatures via extracted logic of Workspaceconfigurer
- since repository import method is defined by the new interface it should be triggered by all commandlets that are implementing this interface
- configureWorkspace now needs to be public
- added env variable to override default config dir of spyder with specific IDEasy configdir
- added logic to set working directory for spyder
- added new merge for .ini files
- added Merger for .ini files
- fixed tests
- refactoring
- refactoring
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 31789612151

Warning

No base build found for commit 31dabbf on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 72.441%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 17680
Covered Lines: 13357
Line Coverage: 75.55%
Relevant Branches: 7811
Covered Branches: 5109
Branch Coverage: 65.41%
Branches in Coverage %: Yes
Coverage Strength: 3.21 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

Rework spyder as IdeToolCommandlet

2 participants