#821: make ide prefix editable in ide shell to allow non-ide commands - #2288
Merged
hohwille merged 6 commits intoAug 18, 2026
Merged
Conversation
Collaborator
Coverage Report for CI Build 32155382505Coverage increased (+0.02%) to 72.952%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions46 previously-covered lines in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
samuelkos17
reviewed
Aug 7, 2026
samuelkos17
left a comment
Contributor
There was a problem hiding this comment.
Once again great work! I've ran through your testing instructions and everything works perfectly so I'll move this to In Review 😄
…ide-prefix-shell # Conflicts: # CHANGELOG.adoc
hohwille
approved these changes
Aug 18, 2026
hohwille
left a comment
Member
There was a problem hiding this comment.
@Ali-Shariati-Najafabadi thanks for your PR. From the implementation this looks sane and good to me. 👍
However, I could not test this due to bug #1746 - how did you and @samuelkos17 actually test this? I am confused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #821
Implemented changes:
ideprefix inide shellpart of the editable input line instead of a static, non-editable prompt segment, so it can be removed via backspace when entering non-IDEasy commands (e.g.cd)ShellCommandlet.normalizeLine(String)to strip a leadingidefrom the input line so behavior for IDEasy commands (e.g.ide status) stays unchangedShellCommandletTestcovering the new prefix-normalization behaviorTesting instructions
ide shell$and the input line is pre-filled withidewhich is editablestatus(full lineide status) -> behaves the same as before (equivalent to typingstatusalone)ideand run a non-IDEasy command, e.g.cd ..-> works correctly without the misleadingideprefixmvn -Dtest=ShellCommandletTest testin theclifolder -> all tests passChecklist for this PR
mvn clean testlocally all tests pass and build is successful (except pre-existing unrelated failures, see testing instructions note)#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)internal