Skip to content

feat(mgmt): add outbound SCIM configuration management wrapper#1615

Open
dorsha wants to merge 1 commit into
mainfrom
dorsha/outbound-scim-mgmt
Open

feat(mgmt): add outbound SCIM configuration management wrapper#1615
dorsha wants to merge 1 commit into
mainfrom
dorsha/outbound-scim-mgmt

Conversation

@dorsha

@dorsha dorsha commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds a descope.management.OutboundSCIM module (sync + async) with create_configuration, update_configuration, delete_configuration, load_configuration, load_all_configurations, set_enabled calling the new /v1/mgmt/outbound/scim/* endpoints on the backend (descope/backend#1747).
  • Wires DescopeClient.mgmt.outbound_scim (and its async counterpart).
  • Mirrors the existing outbound_application wrapper conventions (snake_case Python, camelCase wire, dict-typed responses).

Related: descope/etc#15987

Test plan

  • pytest tests/management/test_outbound_scim.py — 34 passed (17 tests × sync+async)
  • pytest tests/management/ — 681 passed, no regressions
  • ruff check descope/ tests/management/test_outbound_scim.py clean
  • ruff format --check clean
  • CI passes

🤖 Generated with Claude Code

Adds descope.management.OutboundSCIM (sync + async) with create_configuration, update_configuration, delete_configuration, load_configuration, load_all_configurations, and set_enabled. Related: descope/etc#15987

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@shuni-bot

shuni-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

🐕 Review complete — View session on Shuni Portal 🐾

@shuni-bot

shuni-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

🐕 Suggested Reviewers

The review assignment focuses on covering different areas of the change, including core management logic, asynchronous components, and integration points. Selected reviewers have committed to relevant files and possess expertise necessary for comprehensive code review.

Reviewer Reason
orius123 has multiple commits across common management files and mgmt.py, indicating deep involvement in core management functionalities, suitable for reviewing overall module integrations.
omercnet also contributed to common management code and mgmt.py, bringing useful perspective on shared code and potential impacts on management workflows.
LioriE contributed to common and mgmt_async.py, providing asynchronous expertise, essential for reviewing the async components of the new outbound SCIM management wrapper.
ckiee made a commit on mgmt.py, familiar with the management layer and its interface design, suitable for reviewing how the new wrapper integrates with existing management functions.
gaokevin1 contributed to mgmt.py, offering additional insights on the management interface and its extension to support new configurations.

Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best.

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni's Review

Adds the OutboundSCIM management wrapper (sync + async) with CRUD + set_enabled, wired into mgmt/mgmt_async, mirroring the outbound_application conventions.

No issues found — good bones! Sync/async parity is clean, bodies serialize to camelCase correctly, load-by-id vs load-all paths are consistent with the tests, and management-key gating is in place. Woof!

@github-actions

Copy link
Copy Markdown

Coverage report

The coverage rate went from 98.24% to 98.27% ⬆️

100% of new lines are covered.

Diff Coverage details (click to unfold)

descope/management/_outbound_scim_base.py

100% of new lines are covered (100% of the complete file).

descope/management/common.py

100% of new lines are covered (99.78% of the complete file).

descope/management/outbound_scim_async.py

100% of new lines are covered (100% of the complete file).

descope/management/outbound_scim.py

100% of new lines are covered (100% of the complete file).

descope/mgmt.py

100% of new lines are covered (100% of the complete file).

descope/mgmt_async.py

100% of new lines are covered (100% of the complete file).

@dorsha dorsha requested a review from aviadl July 10, 2026 19:02
@dorsha dorsha enabled auto-merge (squash) July 10, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant