docs: 3.0 doc updates (ToolInvoker/Generator removal, required_variables default, logging/tracing)#11956
Merged
Merged
Conversation
…d_variables default, logging and tracing changes Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…-doc-fixes # Conflicts: # docs-website/docs/pipeline-components/generators/googleaigeminichatgenerator.mdx # docs-website/docs/pipeline-components/generators/guides-to-generators/function-calling.mdx # docs-website/docs/pipeline-components/generators/vertexaigeminichatgenerator.mdx # docs-website/docs/tools/tool.mdx # docs-website/docs/tools/toolset.mdx
julian-risch
commented
Jul 10, 2026
julian-risch
commented
Jul 10, 2026
julian-risch
commented
Jul 10, 2026
julian-risch
commented
Jul 10, 2026
bogdankostic
left a comment
Contributor
There was a problem hiding this comment.
Looks mostly good, added some comments on stuff that I'm unsure about.
…ation guide) - concepts-overview.mdx: drop the note about legacy non-chat Generators being removed in 3.0 (not relevant for new users). - choosing-the-right-generator.mdx: remove the historical "Generators vs ChatGenerators" section; fold the ChatGenerator description into the intro. - function-calling.mdx: reframe the page as an explanation of what happens under the hood when an Agent runs tools. - aimllapichatgenerator.mdx, cometapichatgenerator.mdx: run the Agent standalone in the tool-calling example instead of wrapping it in a Pipeline, under a new "With an Agent" section. - vertexaigeminichatgenerator.mdx, googleaigeminichatgenerator.mdx, googlegenaichatgenerator.mdx: replace the Agent tip with a full "With an Agent" usage section; fix an undefined-variable typo in the Vertex AI pipeline example. - componenttool.mdx: remove the "In a Pipeline" section that only duplicated the Agent example. - tool.mdx: remove the manual tool-calling sections; the "Passing Tools to Agent" section stays and the usage tip links to the Function Calling guide for the manual loop. - migrating-from-langgraphlangchain-to-haystack.mdx: restructure the agentic walkthrough into 4 steps so every step shows real Haystack code, and retitle "Initialize the LLM with tools" since tools are no longer passed to the ChatGenerator. - migration.mdx: complete revamp to cover the 2.x -> 3.0 migration (based on MIGRATION.md), with a pointer to the preserved 1.x -> 2.x guide; update the FAQ link text accordingly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…on guide Match the MIGRATION.md fix from #11948: HuggingFaceAPIChatGenerator lives in the huggingface-api-haystack integration and HuggingFaceLocalChatGenerator was renamed to TransformersChatGenerator in transformers-haystack, so point readers to the moved-components section instead of implying all chat counterparts are importable from core. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Per review discussion in #11956, the manual tool-call-loop walkthrough adds little value now that the Agent component owns tool execution. Remove the page and its sidebar entry, and describe the manual loop (Tool.invoke + ChatMessage.from_tool) inline where the page was previously linked. The stable /docs/function-calling URL keeps resolving via the versioned 2.x docs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
A. Replace removed
ToolInvokerwithAgent(or manualTool.invoke):docs-website/docs/tools/tool.mdx,toolset.mdx,mcptoolset.mdx,mcptool.mdx,componenttool.mdx,pipelinetool.mdx: ToolInvoker-based examples replaced withAgent-based examples. After review:tool.mdxdrops the manual tool-calling sections entirely (the Passing Tools to Agent section is enough; the usage tip links to the Function Calling guide for the manual loop), andcomponenttool.mdxdrops the In a Pipeline section that only duplicated the Agent example.docs-website/docs/pipeline-components/generators/guides-to-generators/function-calling.mdx: reframed as an explanation of what happens under the hood when anAgentruns tools; the "Actually Invoke the Tool" step usesTool.invoke+ChatMessage.from_tool, and the page closes with theAgentdoing the same loop automatically.docs-website/docs/pipeline-components/generators/googlegenaichatgenerator.mdx(also removes the brokenhttps://www.notion.so/docs/toolinvokerlink),vertexaigeminichatgenerator.mdx,googleaigeminichatgenerator.mdx: broken function-calling examples (undefined variables, removedChatMessage.from_function) rewritten against the current API, each followed by a new With an Agent usage section. Also fixes an undefined-variable typo in the Vertex AI pipeline example.docs-website/docs/pipeline-components/generators/aimllapichatgenerator.mdx,cometapichatgenerator.mdx: tool-calling examples now run theAgentstandalone under a With an Agent section (no unnecessaryPipelinewrapper).docs-website/docs/pipeline-components/agents-1/agent.mdx,state.mdx,guides-to-generators/choosing-the-right-generator.mdx: prose mentions of ToolInvoker recast as the Agent's built-in tool execution (streaming forwarding viatool_streaming_callback_passthrough).docs-website/docs/overview/migrating-from-langgraphlangchain-to-haystack.mdx: the Agentic Flows walkthrough is restructured into 4 steps so every step shows real Haystack code — the old Steps 3–6 (comment-only Haystack columns) are merged into one "Assemble the agent" step comparingAgent(...)with LangGraph's node/edge/StateGraph assembly. Step 2 retitled to "Initialize the LLM" since tools are no longer passed to the ChatGenerator. RemovedAgentBreakpoint/ToolBreakpoint/Snapshotclass names from the comparison table (onlyBreakpoint/PipelineSnapshotexist).docs-website/docs/overview/migration.mdx: completely revamped to cover the 2.x → 3.0 migration (based onMIGRATION.md): removed/renamed components (legacy Generators,ToolInvoker,TransformersSimilarityRanker,DALLEImageGenerator), the moved-to-integration-packages import table, pipeline changes (AsyncPipelinemerge, deserialization allowlist), therequired_variablesdefault, Agent breaking changes, and behavior changes (Document IDs, logging, tracing, warm-up, Answer serialization) — each with before/after snippets and links to the detail pages. The 1.x → 2.x content is replaced by a pointer to its preserved copy on thev2.31.xbranch; the FAQ link text is updated accordingly.B.
required_variablesnew default —PromptBuilder/ChatPromptBuildernow default to"*"andNonewarns.docs-website/docs/pipeline-components/builders/promptbuilder.mdx,chatpromptbuilder.mdx: corrected the "all optional by default" prose, updated examples, and fixed the serialized YAML default (required_variables: '*').C. Generator split framing — legacy non-chat Generators were removed in 3.0, core ships ChatGenerators, and ChatGenerators accept a plain string.
docs-website/docs/pipeline-components/generators/guides-to-generators/choosing-the-right-generator.mdx: the historical "Generators vs ChatGenerators" section is removed after review; the ChatGenerator description (string or Chat Messages input, function calling, multimodal) is folded into the intro.docs-website/docs/concepts/concepts-overview.mdx: stale "two types of Generators" framing reframed around ChatGenerators; the note about the 3.0 removal of legacy Generators is dropped after review (not relevant for new users; upgraders have the migration page).D. Logging — describe the v3 scoped structlog behavior.
docs-website/docs/development/logging.mdx: the formatting handler is installed only for thehaystack/haystack_integrations/haystack_experimentalnamespaces; addedconfigure_logging(logger_name="")(process-wide legacy behavior) andconfigure_logging(propagate=False)(avoid duplicate lines); fixed the env var name toHAYSTACK_LOGGING_IGNORE_STRUCTLOG.E. OpenTelemetry tracing —
OpenTelemetryTraceralready lives inopentelemetry-haystack.docs-website/docs/development/tracing/opentelemetry.mdx: admonition no longer says "deprecated in core / moving"; it states the tracer is provided by the integration and not auto-enabled.F. Pipeline concurrency —
concurrency_limitis not an__init__parameter.docs-website/docs/concepts/pipelines.mdx: corrected to a per-call argument ofrun_async/run_async_generator/stream; noted that syncrunexecutes sequentially.How did you test it?
npm run buildindocs-websitepasses (onBrokenLinks/onBrokenAnchors/onBrokenMarkdownLinksare all set tothrow, so all links and anchors are validated).ruff-format-docsover the code blocks.Notes for the reviewer
migration.mdx.docs-website/docs/pipeline-components/tools/toolinvoker.mdxand thesidebars.jsentry is intentionally left to a separate PR, so the remaining links to that page were removed here but the page itself is untouched.ToolInvokermentions intools/ready-made-tools/*,overview/platform-components.mdx, andconcepts/pipelines/pipeline-breakpoints.mdxare out of scope for this PR and tracked separately.Checklist
docs:.🤖 Generated with Claude Code