Skip to content

docs: 3.0 doc updates (ToolInvoker/Generator removal, required_variables default, logging/tracing)#11956

Merged
julian-risch merged 7 commits into
mainfrom
docs/v3-high-priority-doc-fixes
Jul 13, 2026
Merged

docs: 3.0 doc updates (ToolInvoker/Generator removal, required_variables default, logging/tracing)#11956
julian-risch merged 7 commits into
mainfrom
docs/v3-high-priority-doc-fixes

Conversation

@julian-risch

@julian-risch julian-risch commented Jul 10, 2026

Copy link
Copy Markdown
Member

Related Issues

Proposed Changes:

A. Replace removed ToolInvoker with Agent (or manual Tool.invoke):

  • docs-website/docs/tools/tool.mdx, toolset.mdx, mcptoolset.mdx, mcptool.mdx, componenttool.mdx, pipelinetool.mdx: ToolInvoker-based examples replaced with Agent-based examples. After review: tool.mdx drops the manual tool-calling sections entirely (the Passing Tools to Agent section is enough; the usage tip links to the Function Calling guide for the manual loop), and componenttool.mdx drops the In a Pipeline section that only duplicated the Agent example.
  • docs-website/docs/pipeline-components/generators/guides-to-generators/function-calling.mdx: reframed as an explanation of what happens under the hood when an Agent runs tools; the "Actually Invoke the Tool" step uses Tool.invoke + ChatMessage.from_tool, and the page closes with the Agent doing the same loop automatically.
  • docs-website/docs/pipeline-components/generators/googlegenaichatgenerator.mdx (also removes the broken https://www.notion.so/docs/toolinvoker link), vertexaigeminichatgenerator.mdx, googleaigeminichatgenerator.mdx: broken function-calling examples (undefined variables, removed ChatMessage.from_function) rewritten against the current API, each followed by a new With an Agent usage section. Also fixes an undefined-variable typo in the Vertex AI pipeline example.
  • docs-website/docs/pipeline-components/generators/aimllapichatgenerator.mdx, cometapichatgenerator.mdx: tool-calling examples now run the Agent standalone under a With an Agent section (no unnecessary Pipeline wrapper).
  • docs-website/docs/pipeline-components/agents-1/agent.mdx, state.mdx, guides-to-generators/choosing-the-right-generator.mdx: prose mentions of ToolInvoker recast as the Agent's built-in tool execution (streaming forwarding via tool_streaming_callback_passthrough).
  • docs-website/docs/overview/migrating-from-langgraphlangchain-to-haystack.mdx: the Agentic Flows walkthrough is restructured into 4 steps so every step shows real Haystack code — the old Steps 3–6 (comment-only Haystack columns) are merged into one "Assemble the agent" step comparing Agent(...) with LangGraph's node/edge/StateGraph assembly. Step 2 retitled to "Initialize the LLM" since tools are no longer passed to the ChatGenerator. Removed AgentBreakpoint/ToolBreakpoint/Snapshot class names from the comparison table (only Breakpoint/PipelineSnapshot exist).
  • docs-website/docs/overview/migration.mdx: completely revamped to cover the 2.x → 3.0 migration (based on MIGRATION.md): removed/renamed components (legacy Generators, ToolInvoker, TransformersSimilarityRanker, DALLEImageGenerator), the moved-to-integration-packages import table, pipeline changes (AsyncPipeline merge, deserialization allowlist), the required_variables default, Agent breaking changes, and behavior changes (Document IDs, logging, tracing, warm-up, Answer serialization) — each with before/after snippets and links to the detail pages. The 1.x → 2.x content is replaced by a pointer to its preserved copy on the v2.31.x branch; the FAQ link text is updated accordingly.

B. required_variables new defaultPromptBuilder/ChatPromptBuilder now default to "*" and None warns.

  • docs-website/docs/pipeline-components/builders/promptbuilder.mdx, chatpromptbuilder.mdx: corrected the "all optional by default" prose, updated examples, and fixed the serialized YAML default (required_variables: '*').

C. Generator split framing — legacy non-chat Generators were removed in 3.0, core ships ChatGenerators, and ChatGenerators accept a plain string.

  • docs-website/docs/pipeline-components/generators/guides-to-generators/choosing-the-right-generator.mdx: the historical "Generators vs ChatGenerators" section is removed after review; the ChatGenerator description (string or Chat Messages input, function calling, multimodal) is folded into the intro.
  • docs-website/docs/concepts/concepts-overview.mdx: stale "two types of Generators" framing reframed around ChatGenerators; the note about the 3.0 removal of legacy Generators is dropped after review (not relevant for new users; upgraders have the migration page).

D. Logging — describe the v3 scoped structlog behavior.

  • docs-website/docs/development/logging.mdx: the formatting handler is installed only for the haystack/haystack_integrations/haystack_experimental namespaces; added configure_logging(logger_name="") (process-wide legacy behavior) and configure_logging(propagate=False) (avoid duplicate lines); fixed the env var name to HAYSTACK_LOGGING_IGNORE_STRUCTLOG.

E. OpenTelemetry tracingOpenTelemetryTracer already lives in opentelemetry-haystack.

  • docs-website/docs/development/tracing/opentelemetry.mdx: admonition no longer says "deprecated in core / moving"; it states the tracer is provided by the integration and not auto-enabled.

F. Pipeline concurrencyconcurrency_limit is not an __init__ parameter.

  • docs-website/docs/concepts/pipelines.mdx: corrected to a per-call argument of run_async/run_async_generator/stream; noted that sync run executes sequentially.

How did you test it?

  • npm run build in docs-website passes (onBrokenLinks/onBrokenAnchors/onBrokenMarkdownLinks are all set to throw, so all links and anchors are validated).
  • Pre-commit hooks pass, including ruff-format-docs over the code blocks.

Notes for the reviewer

  • All review comments from the first round are addressed in the latest commit, including the two larger asks: the LangGraph Agentic Flows restructure and the full v2 → v3 revamp of migration.mdx.
  • Deleting docs-website/docs/pipeline-components/tools/toolinvoker.mdx and the sidebars.js entry is intentionally left to a separate PR, so the remaining links to that page were removed here but the page itself is untouched.
  • Remaining ToolInvoker mentions in tools/ready-made-tools/*, overview/platform-components.mdx, and concepts/pipelines/pipeline-breakpoints.mdx are out of scope for this PR and tracked separately.

Checklist

🤖 Generated with Claude Code

…d_variables default, logging and tracing changes

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
haystack-docs Ready Ready Preview, Comment Jul 13, 2026 7:48am

Request Review

…-doc-fixes

# Conflicts:
#	docs-website/docs/pipeline-components/generators/googleaigeminichatgenerator.mdx
#	docs-website/docs/pipeline-components/generators/guides-to-generators/function-calling.mdx
#	docs-website/docs/pipeline-components/generators/vertexaigeminichatgenerator.mdx
#	docs-website/docs/tools/tool.mdx
#	docs-website/docs/tools/toolset.mdx
Comment thread docs-website/docs/tools/tool.mdx Outdated
@julian-risch
julian-risch marked this pull request as ready for review July 10, 2026 14:45
@julian-risch
julian-risch requested a review from a team as a code owner July 10, 2026 14:45
@julian-risch
julian-risch requested review from bogdankostic and removed request for a team July 10, 2026 14:45
Comment thread docs-website/docs/concepts/concepts-overview.mdx Outdated

@bogdankostic bogdankostic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, added some comments on stuff that I'm unsure about.

Comment thread docs-website/docs/overview/migrating-from-langgraphlangchain-to-haystack.mdx Outdated
Comment thread docs-website/docs/overview/migration.mdx
Comment thread docs-website/docs/pipeline-components/generators/aimllapichatgenerator.mdx Outdated
Comment thread docs-website/docs/tools/componenttool.mdx Outdated
Comment thread docs-website/docs/tools/tool.mdx Outdated
…ation guide)

- concepts-overview.mdx: drop the note about legacy non-chat Generators
  being removed in 3.0 (not relevant for new users).
- choosing-the-right-generator.mdx: remove the historical "Generators vs
  ChatGenerators" section; fold the ChatGenerator description into the intro.
- function-calling.mdx: reframe the page as an explanation of what happens
  under the hood when an Agent runs tools.
- aimllapichatgenerator.mdx, cometapichatgenerator.mdx: run the Agent
  standalone in the tool-calling example instead of wrapping it in a Pipeline,
  under a new "With an Agent" section.
- vertexaigeminichatgenerator.mdx, googleaigeminichatgenerator.mdx,
  googlegenaichatgenerator.mdx: replace the Agent tip with a full
  "With an Agent" usage section; fix an undefined-variable typo in the
  Vertex AI pipeline example.
- componenttool.mdx: remove the "In a Pipeline" section that only duplicated
  the Agent example.
- tool.mdx: remove the manual tool-calling sections; the "Passing Tools to
  Agent" section stays and the usage tip links to the Function Calling guide
  for the manual loop.
- migrating-from-langgraphlangchain-to-haystack.mdx: restructure the agentic
  walkthrough into 4 steps so every step shows real Haystack code, and retitle
  "Initialize the LLM with tools" since tools are no longer passed to the
  ChatGenerator.
- migration.mdx: complete revamp to cover the 2.x -> 3.0 migration (based on
  MIGRATION.md), with a pointer to the preserved 1.x -> 2.x guide; update the
  FAQ link text accordingly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@julian-risch julian-risch changed the title docs: high-priority 3.0 doc updates (ToolInvoker/Generator removal, required_variables default, logging/tracing) docs: 3.0 doc updates (ToolInvoker/Generator removal, required_variables default, logging/tracing) Jul 10, 2026
julian-risch and others added 2 commits July 13, 2026 09:38
…on guide

Match the MIGRATION.md fix from #11948: HuggingFaceAPIChatGenerator lives in
the huggingface-api-haystack integration and HuggingFaceLocalChatGenerator was
renamed to TransformersChatGenerator in transformers-haystack, so point readers
to the moved-components section instead of implying all chat counterparts are
importable from core.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Per review discussion in #11956, the manual tool-call-loop walkthrough adds
little value now that the Agent component owns tool execution. Remove the page
and its sidebar entry, and describe the manual loop (Tool.invoke +
ChatMessage.from_tool) inline where the page was previously linked. The stable
/docs/function-calling URL keeps resolving via the versioned 2.x docs.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@bogdankostic bogdankostic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@julian-risch
julian-risch merged commit f0156a8 into main Jul 13, 2026
20 checks passed
@julian-risch
julian-risch deleted the docs/v3-high-priority-doc-fixes branch July 13, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants