fix: make _ToolsetWrapper.__getitem__ support negative indices#11927
Open
Diwak4r wants to merge 1 commit into
Open
fix: make _ToolsetWrapper.__getitem__ support negative indices#11927Diwak4r wants to merge 1 commit into
Diwak4r wants to merge 1 commit into
Conversation
The base Toolset.__getitem__ uses list(self)[index], which handles negative indices, but _ToolsetWrapper used a forward enumerate scan with i == index that only worked for non-negative indices. This made combined_toolsets[-1] raise IndexError, inconsistent with Toolset. Closes deepset-ai#11759
|
@Diwak4r is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_ToolsetWrapper.__getitem__used a forwardenumeratescan withif i == indexthat only worked for non-negative indices. Requesting a negative index (e.g.combined[-1]) raisedIndexError, while the baseToolset.__getitem__correctly handles negative indices vialist(self)[index].Toolset.Closes #11759
Test plan
test_wrapper_getitem_supports_negative_indexandtest_wrapper_getitem_out_of_range_raisesintest/tools/test_toolset_wrapper.py.test/tools/test_toolset_wrapper.pysuite: 16 passed.