fix: Update Document.__eq__ to intelligently compare floats#11828
Open
nigamgauri wants to merge 2 commits into
Open
fix: Update Document.__eq__ to intelligently compare floats#11828nigamgauri wants to merge 2 commits into
nigamgauri wants to merge 2 commits into
Conversation
|
Someone is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Contributor
|
Hey @nigamgauri please sign the CLA agreement #11828 (comment) otherwise we can't accept your contribution. I'll proceed with a review once it's signed. |
nigamgauri
force-pushed
the
fix-document-eq-float-comparison
branch
from
7e5340e to
a022b38
Compare
…-comparison # Conflicts: # haystack/dataclasses/document.py # test/dataclasses/test_document.py
Author
Hi @sjrl, the CLA is signed now and I've resolved the merge conflicts with main. Ready for review whenever you get a chance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Document.__eq__performed strict dictionary equality comparison (self.to_dict() == other.to_dict()) on the serialized representation of two documents. This caused equality checks to fail when float fields (such asscore,embeddingvalues,sparse_embeddingvalues, or nested floats inmeta) differed very slightly due to floating-point imprecision.This PR replaces the strict comparison in
Document.__eq__with a recursive structure comparison helper (_recursive_is_close) that usesmath.isclose(with a relative/absolute tolerance of1e-7) when encountering floating-point numbers.How did you test it?
test/dataclasses/test_document.pyverifying float comparisons forscore,embedding,sparse_embedding, and nestedmetafields.hatch run fmt), and type checks (hatch run test:types) pass successfully.