Skip to content

Made sidebar have fixed position - #339

Merged
def- merged 1 commit into
ddnet:masterfrom
KollPotato:pr-fixed-sidebar
Sep 21, 2026
Merged

def- merged 1 commit into
ddnet:masterfrom
KollPotato:pr-fixed-sidebar

Conversation

@KollPotato

Copy link
Copy Markdown
Contributor

Fixes #338.

Works on my machine, here is proof:

fixed.sidebar.video.mp4

@Robyt3 Robyt3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it work on mobile?

@KollPotato

Copy link
Copy Markdown
Contributor Author

I have tested it in the dev tools on my desktop and also on my phone, works exactly like before.

@KollPotato

Copy link
Copy Markdown
Contributor Author
YouCut_20250823_191335036.mp4

@KollPotato

Copy link
Copy Markdown
Contributor Author

DON'T MERGE!!!! It does not behave as expected on some pages.

@ChillerDragon
ChillerDragon marked this pull request as draft August 23, 2025 16:32
@KollPotato

Copy link
Copy Markdown
Contributor Author

I changed so if there is an overflow the sidebar is scrollable, otherwise no scrollbar is shown.

image image

@KollPotato
KollPotato marked this pull request as ready for review August 23, 2025 16:54
@KollPotato
KollPotato requested a review from Robyt3 August 29, 2025 16:37
@Robyt3

Robyt3 commented Aug 29, 2025

Copy link
Copy Markdown
Member

The navigation scrollbar overlapping the content doesn't look good to me. The scrollbar being visible with a common screen size like 1920x1080 also doesn't look good.

image

@KollPotato

KollPotato commented Aug 30, 2025 •

Copy link
Copy Markdown
Contributor Author

The scrollbar being visible with a common screen size like 1920x1080 also doesn't look good.

It is intentional that scrollbar only shows up when content doesn't fit screen height

@Robyt3

Robyt3 commented Aug 30, 2025

Copy link
Copy Markdown
Member

This now applies a transition: 0.4s; property to all elements, so the navigation position weirdly transitions when you resize the window, and highlighting of hovered links is barely visible anymore due to the slow transition.

@Pioooooo Pioooooo mentioned this pull request Dec 10, 2025
@KollPotato

Copy link
Copy Markdown
Contributor Author

I got a bit lost on this problem last year xD

@Robyt3 can you send a video of the weird transition you mentioned? I am unable to notice it myself and don't think this PR could have influenced transitions of other elements.

@Robyt3

Robyt3 commented Sep 20, 2026

Copy link
Copy Markdown
Member

@Robyt3 can you send a video of the weird transition you mentioned? I am unable to notice it myself and don't think this PR could have influenced transitions of other elements.

I only could only reproduce it once now in Firefox, but it doesn't seem to happen consistently and I can't get it to happen a second time. All I did was load ddnet.org with the default theme and replace the contents of css.css with the file from this PR using the browser developer console then resize the window so the navigation changes to horizontal.

Please squash the commits into one in any case.

Fix logo being overlapped
@KollPotato

Copy link
Copy Markdown
Contributor Author

Please squash the commits into one in any case.

Squashed and ready to go.

@Robyt3
Robyt3 requested a review from def- September 20, 2026 11:29
@def-

def- commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Sorry for not having noticed this PR before. I don't like fixed position of sidebar, so I made it non-fixed a while ago. I like it when the entire site is one block that moves all together, as it currently does. But maybe that's just me and others think it's better?

Edit: The implementation itself seems fine, so if we want to go with it, fine to merge.

@def-
def- merged commit 2f2a0f5 into ddnet:master Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixed sidebar on homepage

3 participants