Repository navigation
Made sidebar have fixed position - #339
Conversation
|
I have tested it in the dev tools on my desktop and also on my phone, works exactly like before. |
YouCut_20250823_191335036.mp4 |
|
DON'T MERGE!!!! It does not behave as expected on some pages. |
e8d8e3e to
84ed4d0
Compare
It is intentional that scrollbar only shows up when content doesn't fit screen height |
84ed4d0 to
f82a9a5
Compare
|
This now applies a |
|
I got a bit lost on this problem last year xD @Robyt3 can you send a video of the weird transition you mentioned? I am unable to notice it myself and don't think this PR could have influenced transitions of other elements. |
I only could only reproduce it once now in Firefox, but it doesn't seem to happen consistently and I can't get it to happen a second time. All I did was load ddnet.org with the default theme and replace the contents of Please squash the commits into one in any case. |
Fix logo being overlapped
6c45690 to
c1f9e00
Compare
Squashed and ready to go. |
|
Sorry for not having noticed this PR before. I don't like fixed position of sidebar, so I made it non-fixed a while ago. I like it when the entire site is one block that moves all together, as it currently does. But maybe that's just me and others think it's better? Edit: The implementation itself seems fine, so if we want to go with it, fine to merge. |



Fixes #338.
Works on my machine, here is proof:
fixed.sidebar.video.mp4