-
Notifications
You must be signed in to change notification settings - Fork 602
Add support for -f/--file option to execute SQL from files #1543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DiegoDAF
wants to merge
3
commits into
dbcli:main
Choose a base branch
from
DiegoDAF:feature/file-option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+213
−1
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| Feature: run the cli with -f/--file option, | ||
| execute commands from file, | ||
| and exit | ||
|
|
||
| Scenario: run pgcli with -f and a SQL query file | ||
| When we create a file with "SELECT 1 as test_diego_column" | ||
| and we run pgcli with -f and the file | ||
| then we see the query result | ||
| and pgcli exits successfully | ||
|
|
||
| Scenario: run pgcli with --file and a SQL query file | ||
| When we create a file with "SELECT 'hello' as greeting" | ||
| and we run pgcli with --file and the file | ||
| then we see the query result | ||
| and pgcli exits successfully | ||
|
|
||
| Scenario: run pgcli with -f and a file with special command | ||
| When we create a file with "\dt" | ||
| and we run pgcli with -f and the file | ||
| then we see the command output | ||
| and pgcli exits successfully | ||
|
|
||
| Scenario: run pgcli with -f and a file with multiple statements | ||
| When we create a file with "SELECT 1; SELECT 2" | ||
| and we run pgcli with -f and the file | ||
| then we see both query results | ||
| and pgcli exits successfully | ||
|
|
||
| Scenario: run pgcli with -f and a file with an invalid query | ||
| When we create a file with "SELECT invalid_column FROM nonexistent_table" | ||
| and we run pgcli with -f and the file | ||
| then we see an error message | ||
| and pgcli exits successfully |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,137 @@ | ||
| """ | ||
| Steps for testing -f/--file option behavioral tests. | ||
| """ | ||
|
|
||
| import subprocess | ||
| import tempfile | ||
| import os | ||
| from behave import when, then | ||
|
|
||
|
|
||
| @when('we create a file with "{content}"') | ||
| def step_create_file_with_content(context, content): | ||
| """Create a temporary file with the given content.""" | ||
| # Create a temporary file that will be cleaned up automatically | ||
| temp_file = tempfile.NamedTemporaryFile(mode='w', delete=False, suffix='.sql') | ||
| temp_file.write(content) | ||
| temp_file.close() | ||
| context.temp_file_path = temp_file.name | ||
|
|
||
|
|
||
| @when('we run pgcli with -f and the file') | ||
| def step_run_pgcli_with_f(context): | ||
| """Run pgcli with -f flag and the temporary file.""" | ||
| cmd = [ | ||
| "pgcli", | ||
| "-h", | ||
| context.conf["host"], | ||
| "-p", | ||
| str(context.conf["port"]), | ||
| "-U", | ||
| context.conf["user"], | ||
| "-d", | ||
| context.conf["dbname"], | ||
| "-f", | ||
| context.temp_file_path, | ||
| ] | ||
| try: | ||
| context.cmd_output = subprocess.check_output(cmd, cwd=context.package_root, stderr=subprocess.STDOUT, timeout=5) | ||
| context.exit_code = 0 | ||
| except subprocess.CalledProcessError as e: | ||
| context.cmd_output = e.output | ||
| context.exit_code = e.returncode | ||
| except subprocess.TimeoutExpired: | ||
| context.cmd_output = b"Command timed out" | ||
| context.exit_code = -1 | ||
| finally: | ||
| # Clean up the temporary file | ||
| if hasattr(context, 'temp_file_path') and os.path.exists(context.temp_file_path): | ||
| os.unlink(context.temp_file_path) | ||
|
|
||
|
|
||
| @when('we run pgcli with --file and the file') | ||
| def step_run_pgcli_with_file(context): | ||
| """Run pgcli with --file flag and the temporary file.""" | ||
| cmd = [ | ||
| "pgcli", | ||
| "-h", | ||
| context.conf["host"], | ||
| "-p", | ||
| str(context.conf["port"]), | ||
| "-U", | ||
| context.conf["user"], | ||
| "-d", | ||
| context.conf["dbname"], | ||
| "--file", | ||
| context.temp_file_path, | ||
| ] | ||
| try: | ||
| context.cmd_output = subprocess.check_output(cmd, cwd=context.package_root, stderr=subprocess.STDOUT, timeout=5) | ||
| context.exit_code = 0 | ||
| except subprocess.CalledProcessError as e: | ||
| context.cmd_output = e.output | ||
| context.exit_code = e.returncode | ||
| except subprocess.TimeoutExpired: | ||
| context.cmd_output = b"Command timed out" | ||
| context.exit_code = -1 | ||
| finally: | ||
| # Clean up the temporary file | ||
| if hasattr(context, 'temp_file_path') and os.path.exists(context.temp_file_path): | ||
| os.unlink(context.temp_file_path) | ||
|
|
||
|
|
||
| @then("we see the query result") | ||
| def step_see_query_result(context): | ||
| """Verify that the query result is in the output.""" | ||
| output = context.cmd_output.decode('utf-8') | ||
| # Check for common query result indicators | ||
| assert any([ | ||
| "SELECT" in output, | ||
| "test_diego_column" in output, | ||
| "greeting" in output, | ||
| "hello" in output, | ||
| "+-" in output, # table border | ||
| "|" in output, # table column separator | ||
| ]), f"Expected query result in output, but got: {output}" | ||
|
|
||
|
|
||
| @then("we see both query results") | ||
| def step_see_both_query_results(context): | ||
| """Verify that both query results are in the output.""" | ||
| output = context.cmd_output.decode('utf-8') | ||
| # Should contain output from both SELECT statements | ||
| assert "SELECT" in output, f"Expected SELECT in output, but got: {output}" | ||
| # The output should have multiple result sets | ||
| assert output.count("SELECT") >= 2, f"Expected at least 2 SELECT results, but got: {output}" | ||
|
|
||
|
|
||
| @then("we see the command output") | ||
| def step_see_command_output(context): | ||
| """Verify that the special command output is present.""" | ||
| output = context.cmd_output.decode('utf-8') | ||
| # `\dt` renders its column headers whether or not any tables exist, so the | ||
| # headers are what tells us the special command actually ran and produced | ||
| # its listing (rather than erroring out). | ||
| for header in ("Schema", "Name", "Type", "Owner"): | ||
| assert header in output, f"Expected {header!r} in \\dt output, but got: {output}" | ||
| assert context.exit_code == 0, f"Expected exit code 0, but got: {context.exit_code}" | ||
|
|
||
|
|
||
| @then("we see an error message") | ||
| def step_see_error_message(context): | ||
| """Verify that an error message is in the output.""" | ||
| output = context.cmd_output.decode('utf-8') | ||
| assert any([ | ||
| "does not exist" in output, | ||
| "error" in output.lower(), | ||
| "ERROR" in output, | ||
| ]), f"Expected error message in output, but got: {output}" | ||
|
|
||
|
|
||
| @then("pgcli exits successfully") | ||
| def step_pgcli_exits_successfully(context): | ||
| """Verify that pgcli exited with code 0.""" | ||
| assert context.exit_code == 0, f"Expected exit code 0, but got: {context.exit_code}" | ||
| # Clean up | ||
| context.cmd_output = None | ||
| context.exit_code = None | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.