Improve acceptance of a DSN as a positional argument - #2070
Merged
Conversation
rolandwalker
force-pushed
the
RW/improve-dsn-as-positional-argument
branch
from
July 31, 2026 12:07
12b84a1 to
801fce2
Compare
* don't let a --password argument indicate that an ambiguous DSN alias is a database name. We generally expect passwords to be given separately from a DSN. * do let an explicit --socket argument suggest that an ambiguous argument is a database name rather than a DSN alias. * emit a warning on taking an ambiguous argument to be a database name, when it also exists as a DSN alias. * complete DSN aliases as positional arguments outside of the first position in zsh. * accept DSN aliases as zsh completions after --database or -D. This is weird, but we do accept DSNs there, so we might as well offer the completions. There is some effect on non-positional DSN values, but the changes mostly concern positional arguments.
rolandwalker
force-pushed
the
RW/improve-dsn-as-positional-argument
branch
from
July 31, 2026 12:11
801fce2 to
3ab370d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--passwordargument indicate that an ambiguous DSN alias is a database name. We generally expect passwords to be given separately from a DSN.--socketargument suggest that an ambiguous argument is a database name rather than a DSN alias.--databaseor-D. This is weird, but we do accept DSNs there, so we might as well offer the completions.There is some effect on non-positional DSN values, but the changes mostly concern positional arguments.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).