Skip to content

remove unused enable_gemini_3_flash feature flag. - #6345

Merged
shixiao-coder merged 16 commits into
datacommonsorg:masterfrom
shixiao-coder:remove-legacy-gemini-3-flag
Aug 10, 2026
Merged

remove unused enable_gemini_3_flash feature flag.#6345
shixiao-coder merged 16 commits into
datacommonsorg:masterfrom
shixiao-coder:remove-legacy-gemini-3-flag

Conversation

@shixiao-coder

Copy link
Copy Markdown
Contributor

The enable_gemini_3_flash was fully migrated over 1 month ago and related legacy code removed 2 weeks ago, now removing the last pice (enable_gemini_3_flash flag) of the migration

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request completes the cleanup process for the 'enable_gemini_3_flash' feature flag. As the migration was finalized and legacy code was previously removed, this change eliminates the final configuration entries across all environments to maintain a clean codebase.

Highlights

  • Feature Flag Cleanup: Removed the 'enable_gemini_3_flash' feature flag from all environment configuration files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the enable_gemini_3_flash feature flag from all environment configuration files, including autopush, custom, dev, local, production, and staging. No review comments were provided, and I have no feedback to offer.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@shixiao-coder
shixiao-coder requested a review from gmechali June 8, 2026 13:54
Comment thread server/config/feature_flag_configs/production.json

@gmechali gmechali left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than production.json, looks good

@shixiao-coder
shixiao-coder requested a review from a team as a code owner August 7, 2026 18:43
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

⚠️ PRODUCTION FEATURE FLAG CHANGE — REVIEW CHECKLIST

Please conduct a careful review before merging this production change & coordinate with the oncaller.
Merging this PR will trigger a rolling restart of all Kubernetes pods in production.

Things to check before approving:

  • Staging Validated: Have these exact flag changes been tested and verified in staging?
  • Cache Invalidation: If API responses change, remember to clear the Redis cache after merging.
  • Time Window: Ensure updates occur during global working hours; request lead approval for Friday–Sunday updates.
  • Oncall Communication: Please additionally announce this update on the oncall thread.
  • Type Safety: Verify that flag value types match what the server binary expects.

@dhotchkiss dhotchkiss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate seeing the follow-through to clean up obsolete flags. Thank you Xiao!

@shixiao-coder
shixiao-coder merged commit 6eec193 into datacommonsorg:master Aug 10, 2026
18 checks passed
@shixiao-coder
shixiao-coder deleted the remove-legacy-gemini-3-flag branch August 10, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants