Skip to content

testing#2077

Open
niveditasing wants to merge 2 commits into
datacommonsorg:masterfrom
niveditasing:world_bank_gcs
Open

testing#2077
niveditasing wants to merge 2 commits into
datacommonsorg:masterfrom
niveditasing:world_bank_gcs

Conversation

@niveditasing

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new GCS path flag and logic to merge and deduplicate deleted historical data into the processed output. The review feedback points out that importing and using pandas introduces an unnecessary external dependency and risks silent data corruption due to automatic type inference. It is recommended to use Python's built-in csv module to safely perform the merge and deduplication instead.

Comment thread scripts/world_bank/datasets/process.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant