Add per-task-type deploy telemetry for bundle jobs - #6678
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: b7b7989
Top 4 slowest tests (at least 2 minutes):
|
ben-hansen-db
approved these changes
Sep 14, 2026
ben-hansen-db
left a comment
Contributor
There was a problem hiding this comment.
Looks good from my perspective. Is there any proto we need to update? Where does the data end up?
| // Record AI Runtime (ai_runtime_task / BYOT) adoption. has_ai_runtime_task is | ||
| // emitted on every deploy; the rest describe the ai_runtime_task jobs and are | ||
| // emitted only when one is present. | ||
| airPresent, airScheduled, airMultitask := aiRuntimeTaskMetrics(b.Config.Resources.Jobs) |
Contributor
There was a problem hiding this comment.
does this need a proto update somewhere?
Contributor
|
Oh I see this shows up already in that's great |
Record which task types a deployed bundle uses: one has_<task_type> boolean per task type present (notebook_task, spark_python_task, ai_runtime_task, ...), determined generically by reflecting over the task's type fields so new task types are captured without changes here. for_each_task is unwrapped so the wrapped task's type is recorded too. Also emit two ai_runtime_task-specific dimensions when one is present: ai_runtime_task_scheduled and ai_runtime_task_multitask. All of these use the existing bool_values field on BundleDeployEvent, so no proto change is required. Regenerates the telemetry acceptance goldens, which now carry the has_<task_type> keys for the tasks in their fixtures. Co-authored-by: Isaac <no-reply@databricks.com>
vinchenzo-db
force-pushed
the
air-runtime-task-deploy-telemetry
branch
from
September 14, 2026 18:57
588db76 to
a22f0cc
Compare
Fixes the govet/modernize lint failure (Constant reflect.Ptr should be inlined). Co-authored-by: Isaac <no-reply@databricks.com>
pietern
reviewed
Sep 15, 2026
| ] | ||
|
|
||
| # The Terraform provider dropped `code_source_path` from `ai_runtime_task` in | ||
| # v1.122.0, so this feature is only exercisable via the direct engine. |
Contributor
There was a problem hiding this comment.
Do you have more info about this? If it's in the API definition it should show up in TF.
| @@ -0,0 +1,5 @@ | |||
| trace $CLI bundle deploy | |||
|
|
|||
| trace cat "$OUT_REQUESTS" | jq 'select(has("path") and .path == "/telemetry-ext") | .body.protoLogs[] | fromjson | .entry.databricks_cli_log.bundle_deploy_event.experimental | {bool_values}' | |||
Contributor
There was a problem hiding this comment.
Please limit this to the values you care about.
I think only has_*_task and ai_runtime_*.
The output will otherwise churn on unrelated changes.
- Drop code_source_path and the artifact/sync machinery: it isn't needed to exercise the telemetry bools and was the only reason the test was pinned to the direct engine. The fixture now runs on both engines (terraform included), since code_source_path was the sole ai_runtime_task field missing from the Terraform provider. - Filter the recorded bool_values to the has_*_task / ai_runtime_* keys so the golden does not churn when unrelated telemetry values change. Co-authored-by: Isaac <no-reply@databricks.com>
pietern
approved these changes
Sep 15, 2026
janniklasrose
pushed a commit
that referenced
this pull request
Sep 15, 2026
## Changes With this change we hope to catch the following telemetry: - Record job task types (has_<task_type>) in bundle deploy telemetry - Add task-type deploy telemetry (all job task types + ai_runtime_task scheduling/multitask) ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> ## Tests <!-- How have you tested the changes? --> <!-- If your PR needs to be included in the release notes for next release, add a changelog fragment: create .nextchanges/<section>/<name>.md with a one-line description (e.g. .nextchanges/cli/quickstart.md). See .nextchanges/README.md. --> --------- Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: ac1719d
262 interesting tests: 254 FAIL, 7 KNOWN, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
With this change we hope to catch the following telemetry:
Why
Tests