Move U2M authentication implementation into the CLI - #6540
Merged
Conversation
Collaborator
Integration test reportCommit: f8b3b93
Top 6 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Moves interactive U2M authentication and token caching into a CLI-owned
libs/auth/u2mpackage and updates all CLI callers to use it. The implementation preserves the SDK behavior while routing browser launches through the CLI browser abstraction.Note: This PR purely aims at collocating the code by moving the CLI relevant parts back to the CLI repo. This PR will be followed by subsequent PRs to simplify the implementation now that all code is collocated.
Why
Interactive login and persistent token storage are CLI responsibilities, but the CLI depended on SDK types such as
PersistentAuththat the SDK itself does not use for authentication. Owning these pieces in the CLI removes that cross-layer dependency.Tests
./task lint: Go lint passes with zero issues; Python lint could not download Ruff because DNS is unavailable./task test: all 9,650 unit tests pass; acceptance prerequisites fail because the installed jq is 1.6 and the suite requires 1.7Written with Codex.