direct: pass last-persisted state to DoDelete#5279
Open
pietern wants to merge 1 commit into
Open
Conversation
Extends IResource.DoDelete to take the resource's last-persisted state alongside id. The framework loads it from dstate in DeploymentUnit.Delete and DeploymentUnit.Recreate, and Adapter.DoDelete forwards it to the resource implementation. No behavioral change in this PR: every existing resource ignores the new argument (_ *FooState). Motivation: some delete APIs need values that come from local config (e.g. postgres_project.purge_on_delete, which is set on the user's resource and forwarded to the Lakebase DeleteProject RPC). Today there is nowhere to plumb those values because DoDelete only sees the resource id. This change keeps the call symmetric with DoCreate/DoUpdate, which already receive state. Co-authored-by: Isaac
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
IResource.DoDeleteto take the resource's last-persisted state alongsideid. The framework loads it fromdstateinDeploymentUnit.DeleteandDeploymentUnit.Recreate, andAdapter.DoDeleteforwards it to the resource implementation. No behavioral change in this PR: every existing resource ignores the new argument (_ *FooState).Motivation: some delete APIs need values that come from local config (e.g.
postgres_project.purge_on_delete, which is set on the user's resource and forwarded to the Lakebase DeleteProject RPC). Today there is nowhere to plumb those values becauseDoDeleteonly sees the resource id. This change keeps the call symmetric withDoCreate/DoUpdate, which already receive state.Adapter-level validation now type-checks
DoDelete statethe same way it already does forDoCreate newState.Test plan
go test ./bundle/...,go test ./acceptance/...); no fixture updates needed since behavior is unchanged.This pull request and its description were written by Isaac.