Skip to content

Deploy on push to main #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreasArvidsson merged 1 commit into from
Mar 30, 2026
Merged

Deploy on push to main #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,23 @@
name: Deploy

on:
workflow_dispatch:
workflow_run:
workflows: [Test]
types: [completed]
branches: [main]
Comment on lines +4 to +7

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restrict deploy trigger to push-based test runs

This workflow now triggers on any completed Test run on main, but Test also runs for pull_request events (.github/workflows/test.yaml), and workflow_run jobs can access privileged secrets/tokens; without checking github.event.workflow_run.event == 'push', a successful PR-originated test run can enter this deploy path and publish/tag code outside the intended post-merge release flow. Add an explicit event guard (and optionally same-repo guard) so only main-branch push test runs can deploy.

Useful? React with 👍 / 👎.


jobs:
publish-extension:
name: Publish to marketplace
runs-on: ubuntu-latest
environment: production
if: ${{ github.event.workflow_run.conclusion == 'success' }}

steps:
- name: Checkout repository
uses: actions/checkout@v6
with:
ref: ${{ github.event.workflow_run.head_sha }}

- name: Set up Node.js
uses: actions/setup-node@v6
Expand Down