fix: returns error when closing call fails - resolves potential bug#101
Open
rosygmiki wants to merge 1 commit into
Open
fix: returns error when closing call fails - resolves potential bug#101rosygmiki wants to merge 1 commit into
rosygmiki wants to merge 1 commit into
Conversation
Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in pkg/tar-patch/apply.go where an error encountered while closing the current file was being ignored and nil was returned instead of the actual error. The code has been corrected to return the err. There are no review comments to address.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
=======================================
Coverage 79.19% 79.19%
=======================================
Files 10 10
Lines 1115 1115
=======================================
Hits 883 883
Misses 134 134
Partials 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.