Repository navigation
fstest: match Windows metadata files in walker path form - #341
Merged
Merged
Conversation
Follow-up to containerd#281, which replaced the continuity manifest in fstest with a local walker. The walker builds resource paths with forward slashes rooted at "/", but the Windows metadataFiles list still used the manifest's backslash form. No entry matched, so CheckDirectoryEqual reported the system entries of a mounted Windows layer as additions. List the metadata files in the walker's path form and add a Windows-only test that checks these entries are ignored and that other additions are still reported. Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
fix-fstests-windows
branch
from
October 29, 2026 22:47
a484fd2 to
4b686cb
Compare
austinvazquez
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #281, which replaced the continuity manifest in fstest with a local walker. The walker builds resource paths with forward slashes rooted at "/", but the Windows metadataFiles list still used the manifest's backslash form. No entry matched, so CheckDirectoryEqual reported the system entries of a mounted Windows layer as additions.
List the metadata files in the walker's path form and add a Windows-only test that checks these entries are ignored and that other additions are still reported.