Skip to content

chore: Backport structarmed.php from 4.8 to develop and use baseline config - #10544

Merged
samsonasik merged 5 commits into
codeigniter4:developfrom
samsonasik:chore-sync-structarmed
Sep 12, 2026
Merged

chore: Backport structarmed.php from 4.8 to develop and use baseline config#10544
samsonasik merged 5 commits into
codeigniter4:developfrom
samsonasik:chore-sync-structarmed

Conversation

@samsonasik

Copy link
Copy Markdown
Member

Description

@paulbalandan Per our discussion on #10531 (review) , this PR:

  • cherry-pick structarmed.php from 4.8 to develop
  • generate baseline file config to avoid conflict skip rules apply since in develop, base classes still non abstract on develop.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik samsonasik changed the title chore: cherry-pick structarmed.php from 4.8 to develop and use baseline config chore: Backport structarmed.php from 4.8 to develop and use baseline config Sep 12, 2026
@samsonasik
samsonasik marked this pull request as draft September 12, 2026 13:10
@samsonasik
samsonasik marked this pull request as ready for review September 12, 2026 13:19
@samsonasik samsonasik self-assigned this Sep 12, 2026
@samsonasik

Copy link
Copy Markdown
Member Author

@paulbalandan all green 🎉 , I tested manually, no merge conflict 👍 .

We can regenerate structarmed-baseline.php again later to cleanup skip violations when 4.8 become develop later 👍

@samsonasik
samsonasik merged commit 538c762 into codeigniter4:develop Sep 12, 2026
11 checks passed
@samsonasik
samsonasik deleted the chore-sync-structarmed branch September 12, 2026 13:23
@paulbalandan

Copy link
Copy Markdown
Member

The baseline fails on rector

@samsonasik

Copy link
Copy Markdown
Member Author

I see, since baseline is generated, that should be skipped in rector.php, I will do it

@samsonasik

Copy link
Copy Markdown
Member Author

@paulbalandan here new PR to skip structarmed-baseline.php on rector.php config:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants