Skip to content

Remove dead Stripe Checkout v1 code and gem - #2813

Merged
mroderick merged 1 commit into
masterfrom
feature/remove-dead-stripe-checkout
Aug 27, 2026
Merged

Remove dead Stripe Checkout v1 code and gem#2813
mroderick merged 1 commit into
masterfrom
feature/remove-dead-stripe-checkout

Conversation

@mroderick

Copy link
Copy Markdown
Collaborator

Stripe Checkout v1 was sunset by Stripe in 2022. The payments#new form view was deleted in July 2022 (commit f25f10b8), leaving the controller, JS, Stripe initialiser, route, and tests as unreachable dead code.

The donation page (/donate) only links to external platforms (Enthuse, Open Collective, GitHub Sponsors, etc.) — there is no inline payment flow.

Removed

  • app/assets/javascripts/payments.js — StripeCheckout.configure() handler
  • app/controllers/payments_controller.rb
  • app/views/payments/create.html.haml
  • spec/controllers/payments_controller_spec.rb
  • config/initializers/stripe.rb
  • stripe gem from Gemfile

Updated

  • config/routes.rb — removed resources :payments
  • config/initializers/assets.rb — removed payments.js precompile

Verification

  • Controller specs: 153 examples, 0 failures
  • Model specs: 335 examples, 0 failures
  • Feature specs: 302 examples, 0 failures

@mroderick
mroderick requested a review from olleolleolle August 26, 2026 20:23
@mroderick
mroderick marked this pull request as ready for review August 26, 2026 20:23

@olleolleolle olleolleolle left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing cleanup!

@mroderick
mroderick merged commit c6d3f70 into master Aug 27, 2026
10 checks passed
@mroderick
mroderick deleted the feature/remove-dead-stripe-checkout branch August 27, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants