code format#486
Open
nihussmann wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR primarily applies formatting/cleanup changes across Groovy tests, documentation, and configuration files to standardize imports, indentation, and line-wrapping.
Changes:
- Reformat Groovy test sources (imports, indentation, line wrapping) and a few Groovy main sources.
- Reformat multiple Markdown docs and JSON/YAML/FTL test resources for readability/consistency.
- Reformat CI/workflow and tool config files (e.g., Renovate, GitHub Actions YAML).
Reviewed changes
Copilot reviewed 33 out of 43 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/groovy/com/cloudogu/gitops/utils/git/ScmManagerMock.groovy | Formatting updates to the SCMM test double. |
| src/test/groovy/com/cloudogu/gitops/utils/FileSystemUtilsTest.groovy | Formatting updates to filesystem utility tests. |
| src/test/groovy/com/cloudogu/gitops/utils/data/contentRepos/folderBasedRepo1/common/repo/some.yaml.ftl | Formatting update in templated YAML test resource. |
| src/test/groovy/com/cloudogu/gitops/utils/AirGappedUtilsTest.groovy | Formatting updates in air-gapped utility tests. |
| src/test/groovy/com/cloudogu/gitops/kubernetes/rbac/RbacDefinitionTest.groovy | Formatting updates in RBAC definition tests. |
| src/test/groovy/com/cloudogu/gitops/kubernetes/rbac/ArgocdApplicationTest.groovy | Formatting updates in Argo CD application tests. |
| src/test/groovy/com/cloudogu/gitops/integration/profiles/PetclinicProfileTestIT.groovy | Formatting updates in Petclinic profile integration test. |
| src/test/groovy/com/cloudogu/gitops/integration/profiles/MandantProfileTestIT.groovy | Formatting updates in tenant/operator integration test. |
| src/test/groovy/com/cloudogu/gitops/integration/profiles/FullProfileTestIT.groovy | Formatting updates in full profile integration test. |
| src/test/groovy/com/cloudogu/gitops/git/providers/scmmanager/ScmManagerUrlResolverTest.groovy | Formatting updates in URL resolver tests. |
| src/test/groovy/com/cloudogu/gitops/git/providers/scmmanager/ScmManagerSetupTest.groovy | Formatting updates in SCMM setup tests. |
| src/test/groovy/com/cloudogu/gitops/features/JenkinsTest.groovy | Formatting updates in Jenkins feature tests. |
| src/test/groovy/com/cloudogu/gitops/features/deployment/HelmStrategyTest.groovy | Formatting updates in HelmStrategy tests. |
| src/test/groovy/com/cloudogu/gitops/features/CertManagerTest.groovy | Formatting updates in CertManager tests. |
| src/test/groovy/com/cloudogu/gitops/features/argocd/ArgoCDRepoSetupTest.groovy | Formatting updates in ArgoCD repo setup tests. |
| src/test/groovy/com/cloudogu/gitops/ApplicationTest.groovy | Formatting updates in Application tests. |
| src/main/resources/proxy-config.json | Reformat proxy-config JSON for readability. |
| src/main/groovy/com/cloudogu/gitops/kubernetes/api/K8sJavaApiClient.groovy | Small formatting change in namespace getter. |
| src/main/groovy/com/cloudogu/gitops/Application.groovy | Formatting of secret-writing helper method. |
| renovate.json | Reformat Renovate config JSON. |
| README.md | Reflow and formatting updates to README content. |
| docs/Running-on-Windows-Mac.md | Reflow and formatting updates. |
| docs/k3d.md | Reflow and formatting updates. |
| docs/Installation.md | Reflow and formatting updates. |
| docs/Developers.md | Reflow and formatting updates. |
| docs/Deploy-Ingress-Controller.md | Reflow and formatting updates. |
| docs/content-loader/content-loader.md | Reflow and formatting updates. |
| docs/Configuration.md | Table formatting and reflow updates. |
| docs/Applications.md | Reflow and formatting updates. |
| argocd/cluster-resources/apps/jenkins/templates/namespaceJobTemplate.xml.ftl | Formatting updates to Jenkins job template XML. |
| argocd/cluster-resources/apps/argocd/README.md | Reflow and formatting updates. |
| .github/workflows/create-release.yml | Formatting update to GitHub Actions workflow YAML. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+19
to
+23
| someFile.withWriter { | ||
| { | ||
| it.println expectedText | ||
| } | ||
| } |
| namePrefix: ${config.application.namePrefix} | ||
| <#if config.content.variables.someapp??> | ||
| myvar: ${config.content.variables.someapp.somevalue} | ||
| myvar: ${config.content.variables.someapp.somevalue} |
| @@ -20,18 +21,19 @@ We recommend using the `--ingress` and `--base-url` Parameters. | |||
| With these, the applications are made available as subdomains of `base-url`. | |||
|
|
|||
| For example, `--base-url=http://localhost` leads to ` | |||
Comment on lines
9
to
+13
| /** | ||
| * Lightweight test double for ScmManager/GitProvider. | ||
| * - Configurable in-cluster and client bases | ||
| * - Optional namePrefix to model “tenant” behavior | ||
| * - Records createRepository / setRepositoryPermission calls for assertions | ||
| */ | ||
| * - Records createRepository / setRepositoryPermission calls for assertions*/ |
Comment on lines
21
to
+24
| /** | ||
| * This tests can only be successfull, if one of theses profiles used. | ||
| * | ||
| * * To run locally: add -Dmicronaut.environments=content-examples to your execute configuration | ||
| */ | ||
| * * To run locally: add -Dmicronaut.environments=content-examples to your execute configuration*/ |
| "java.util.function.Supplier" | ||
| ], | ||
| [ | ||
| "com.cloudogu.gitops.git.providers.scmmanager.apiUsersApi" |
| namePrefix: ${config.application.namePrefix} | ||
| <#if config.content.variables.someapp??> | ||
| myvar: ${config.content.variables.someapp.somevalue} | ||
| myvar: ${config.content.variables.someapp.somevalue} |
Comment on lines
14
to
+16
| steps: | ||
| - name: Create release | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| tag: ${{ github.ref_name }} | ||
| run: | | ||
| gh release create "$tag" \ | ||
| --repo="$GITHUB_REPOSITORY" \ | ||
| --title="${tag}" \ | ||
| --generate-notes | ||
| - name: Create release | ||
| env: |
Comment on lines
+19
to
+23
| someFile.withWriter { | ||
| { | ||
| it.println expectedText | ||
| } | ||
| } |
Comment on lines
9
to
+13
| /** | ||
| * Lightweight test double for ScmManager/GitProvider. | ||
| * - Configurable in-cluster and client bases | ||
| * - Optional namePrefix to model “tenant” behavior | ||
| * - Records createRepository / setRepositoryPermission calls for assertions | ||
| */ | ||
| * - Records createRepository / setRepositoryPermission calls for assertions*/ |
Comment on lines
21
to
+24
| /** | ||
| * This tests can only be successfull, if one of theses profiles used. | ||
| * | ||
| * * To run locally: add -Dmicronaut.environments=content-examples to your execute configuration | ||
| */ | ||
| * * To run locally: add -Dmicronaut.environments=content-examples to your execute configuration*/ |
Comment on lines
+120
to
+121
| /** | ||
| * tests searches for ingress services and ensure ingress is used as loadbalancer*/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.