chore: remove visualSearch plugin (in-video search) - #1081
Open
tsi wants to merge 1 commit into
Open
Conversation
The visualSearch plugin powered in-video search by appending a `getinfo:search_b64_<query>` flag to the source transformation and fetching the resulting URL for match timestamps. That flag is backed by the `video-clip_1` model, which is being deprecated, so the plugin has no backend left and is dead code. Removes the plugin, its demo pages and its e2e coverage, plus every wiring point: the plugin registry, the /all bundle import, `_initVisualSearch`, `SOURCE_PARAMS`, defaults, config schema, validators, and the internal-analytics payload. The feature was never really released, so this needs no deprecation path. VIDEO-21022
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes VIDEO-21022 — part of epic VIDEO-21021 "Deprecate unused models/transformations".
Why
The
visualSearchplugin powered in-video search by appending agetinfo:search_b64_<query>flag to the source transformation and fetching the resulting URL for match timestamps. That flag is backed by thevideo-clip_1model, which is being deprecated — so the plugin has no backend left and is dead code.The non-player side of the same removal already shipped under VIDEO-21023.
Not a breaking change
visualSearchwas never really released, so this is a straight removal: no deprecation shim, no no-op option left in the schema, no major-version bump. Leaving a dead option in the config would defeat the purpose of the cleanup.What's removed
Deleted
src/plugins/visual-search/— plugin, lazy loader, styles, and theSearchButton/SearchInput/SearchResultscomponentsdocs/visual-search.html,docs/es-modules/visual-search.htmltest/e2e/specs/NonESM/visualSearchPage.spec.ts,test/e2e/src/pom/visualSearchPage.tsUnwired
src/plugins/index.js— import + registry entrysrc/index.all.js—/allbundle importsrc/video-player.js—_initVisualSearch()and its_initPlugins()callsrc/video-player.const.js—'visualSearch'fromSOURCE_PARAMSsrc/config/defaults.js,src/config/configSchema.json,src/validators/validators.jssrc/utils/get-analytics-player-options.js— the internal-analytics fieldsrc/video-player.utils.js— stale example in a commentPageManagerentriesNothing in
webpack/,rollup.esm.config.js,types/, or the bundlewatch config referenced the plugin.docs/es-modules/vite.config.jsglobs*.html, so deleting the demo page was sufficient.Notes
filterDefaultsAndNullsalready dropped it whenever it matched thefalsedefault, so it only ever appeared for users who explicitly opted in.g_track_personpattern in this epic, a PM release note may follow once this ships.Verification
eslint srccleantsc --noEmitcleannpm run buildandnpm run build-esboth succeed (only the repo's pre-existing asset-size warnings)git grepfor any spelling ofvisualSearchreturns nothing outside CHANGELOG history