Repository navigation
Conversation
The Cloud Controller v3 API documents STOPPING as a valid state of a process instance. Without it, deserializing process stats fails while an instance is shutting down. Backport of cloudfoundry#1382 to 5.x.x.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1382 to
5.x.x, as requested in the review there.Problem
The Cloud Controller v3 API documents the following values for the
statefield of theprocess stats object:
RUNNING,CRASHED,STARTING,STOPPING,DOWN.ProcessStatecurrently does not includeSTOPPING. If an instance is shutting down while thestats are requested (for example during a restart or a rolling deployment),
ProcessState.from("STOPPING")throws anIllegalArgumentExceptionand the wholeGET /v3/processes/:guid/statsresponse cannot be deserialized.Changes
Same change as in #1382, cherry-picked without conflicts:
STOPPINGtoProcessState. The new value is appended at the end, so the ordinals of theexisting values (used for comparison in
DefaultApplications) stay unchanged.ReactorProcessesTestwith a stats fixture that contains aSTOPPINGinstance.Testing
./mvnw spotless:checkpasses../mvnw clean packagepasses locally on the5.x.xbranch (JDK 21).