Harden CI workflow per zizmor#21
Merged
Merged
Conversation
- Add top-level 'permissions: contents: read' (fixes excessive-permissions) - Set 'persist-credentials: false' on actions/checkout (fixes artipacked) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
361e838 to
06db288
Compare
There was a problem hiding this comment.
Pull request overview
Hardens the CI workflow by reducing default GITHUB_TOKEN permissions and preventing credential persistence during checkout, addressing the two zizmor findings called out in the PR description.
Changes:
- Set workflow-wide
permissions: contents: readto avoid default write-scopedGITHUB_TOKEN. - Configure
actions/checkoutwithpersist-credentials: falseto avoid writing credentials into.git/config.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/push.yml |
Limits GITHUB_TOKEN scope to read-only and disables credential persistence on checkout to reduce token exposure risk. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
babakks
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two zizmor findings on
.github/workflows/push.yml:permissions: contents: readso the workflow no longer runs with default-writeGITHUB_TOKENscopes. The job only checks out code and runsgo test; read is sufficient.with: persist-credentials: falseto the checkout step so the token isn't persisted into.git/config, eliminating a credential-leak vector if a later step ever uploads artifacts.Verification
Run
zizmorwith the config below; expect zero findings:go test ./...still passes.