feat(ui): move focus to the entering Flow step after its transition settles - #9743
Draft
alexcarpenter wants to merge 1 commit into
Draft
feat(ui): move focus to the entering Flow step after its transition settles#9743alexcarpenter wants to merge 1 commit into
alexcarpenter wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 2eb8713 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
useFlowAutoFocus()to the headlessFlowprimitive so a step can name the element that should receive focus once its enter transition settles, and wires it into every Reverification view.Focusing an input as soon as a step mounts scrolls the
overflow: hiddenviewport to reveal an element that is still translated off-screen, which fights the slide animation.Flow.Stepnow waits on the sameuseAnimationsFinishedpath that gates its exit, then focuses withpreventScroll. The initially active step is left to the Dialog or Drawer that opened it; only a closed-to-open change moves focus, and only when focus is currently on the body or insideFlow.Root. A step that closes before it settles drops its pending focus.A view marks its primary control with the returned ref. When several mounted elements in one step are marked, the first in DOM order wins, and an element that unmounts before the step settles is skipped. Outside a
Flow.Stepthe ref is a no-op, so views stay portable.Mosaic
Otpnow forwards its ref to the first slot, following thePhoneInputconvention, so the OTP view can target it.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change