Skip to content

refactor(ui): Improve ActionCard shadow#8625

Open
alexcarpenter wants to merge 2 commits into
mainfrom
carp/simplify-action-card-shadow
Open

refactor(ui): Improve ActionCard shadow#8625
alexcarpenter wants to merge 2 commits into
mainfrom
carp/simplify-action-card-shadow

Conversation

@alexcarpenter
Copy link
Copy Markdown
Member

Description

BEFORE AFTER
Screenshot 2026-05-22 at 9 59 57 AM Screenshot 2026-05-22 at 9 59 07 AM

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 22, 2026 2:01pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 22, 2026

🦋 Changeset detected

Latest commit: 4f41ad9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/ui Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the ui label May 22, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 12120ceb-a55b-4f39-afeb-6eb8f63094ab

📥 Commits

Reviewing files that changed from the base of the PR and between e1773ef and 4f41ad9.

📒 Files selected for processing (2)
  • .changeset/simplify-action-card-shadow.md
  • packages/ui/src/baseTheme.ts

📝 Walkthrough

Walkthrough

This PR simplifies the ActionCard shadow styling in the UI theme. The changeset documents a patch-version bump for @clerk/ui with the note "Simplify ActionCard shadow styling." The implementation in baseTheme.ts replaces the previous approach of composing theme.shadows.$actionCardShadow with a border-alpha shadow with an explicit hard-coded multi-layer boxShadow value using theme.colors.$borderAlpha100.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'refactor(ui): Improve ActionCard shadow' accurately reflects the main change: updating ActionCard shadow styling in the UI package.
Description check ✅ Passed The description includes before/after visual comparisons and acknowledges the UI change, making it related to the changeset despite incomplete checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 22, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8625

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8625

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8625

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8625

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8625

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8625

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8625

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8625

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8625

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8625

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8625

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8625

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8625

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8625

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8625

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8625

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8625

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8625

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8625

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8625

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8625

commit: 4f41ad9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants