Skip to content

test(e2e): move integration tests into suite directories - #10640

Merged
austincalvelage merged 1 commit into
austin/caching-cifrom
austin/integration-tests-by-suite
Nov 4, 2026
Merged

austincalvelage merged 1 commit into
austin/caching-cifrom
austin/integration-tests-by-suite

Conversation

@austincalvelage

Copy link
Copy Markdown
Member

Description

Stacked on #10623.

Integration tests were organized two ways at once: some suites had a directory under integration/tests/, while about 60 tests sat at the top level with only a @suite tag inside the file saying which suite runs them. Turbo scopes cache inputs by path, so every suite had to list integration/tests/* and editing any loose test reran all 26 suites.

Every test now lives under integration/tests/<suite>/. Tests tagged for both @generic and @nextjs live in generic/, and the seven tests that no suite tag selects live in unscheduled/. The --grep scripts and the tags are unchanged; only the import depth changed inside the moved files, and tsc reports no unresolved imports across the tests. The appearance snapshot directory moved with its test.

Each suite's turbo inputs now names its own directories, and scripts/integration-deps.test.mjs keeps them in sync. Running node scripts/integration-hash-matrix.mjs:

Change touches Suites rerun before After
integration/tests/generic/sign-in-flow.test.ts 26 generic, nextjs, nextjs:canary, custom
integration/tests/vue/components.test.ts 1 1
packages/shared/src 26 26

custom still follows generic/ because protect-check.test.ts carries both tags.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Each suite's tests now live under integration/tests/<suite>/, so a
suite's turbo inputs are its own directory rather than every top-level
test file. Tests tagged for both generic and nextjs live in generic/,
and the seven tests no suite tag selects live in unscheduled/. Only the
import depth changed inside the moved files.
@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Nov 4, 2026 2:35am UTC
swingset Building Building Preview Nov 4, 2026 2:35am UTC

Request Review

@changeset-bot

changeset-bot Bot commented Nov 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ace299f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@austincalvelage
austincalvelage merged commit ace299f into austin/caching-ci Nov 4, 2026
10 of 11 checks passed
@austincalvelage
austincalvelage deleted the austin/integration-tests-by-suite branch November 4, 2026 02:36

This branch was successfully deployed

2 active deployments
Preview – swingset — ace299fb Deployed Nov 4, 2026 by vercel[bot]
Preview – clerk-js-sandbox — ace299fb Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant