Repository navigation
ci: split fast checks from slow e2e apply - #131
Merged
Merged
Conversation
herdr-plus is not in homebrew-core; it is already installed as a herdr plugin via cli-tool-setup.toml. The bogus formula made every macOS CI run fail after ~12 minutes of package installs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- ci.yaml: runs on every push/PR (Ubuntu only, ~1 min): init data, render matrix, and a new package-name check against Homebrew API, tap repositories, and apt cache. - e2e.yaml: real `chezmoi apply` on Ubuntu and macOS, only on main pushes touching install logic, weekly, or manual dispatch. - Remove automated_test.yaml, which ran the ~13 min macOS install on every PR and duplicated the render matrix per OS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bind the Ctrl-G sk-git widgets through zsh-defer when available, matching skim.sh and zoxide.sh, so deferred antidote plugins cannot override them. tests/zsh-sk-git.sh has expected this since the module was added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- render-scripts, script-behavior: generate a chezmoi config instead of reading the machine's own, so .xdg/.identity exist in clean environments like CI. - script-behavior: assert the real imperative tool data renders exactly its enabled entries, instead of assuming every entry is disabled; add gzip to the restricted PATH so GNU tar can extract on Linux. - television-git-channels: compare key/value lines ignoring taplo's `=` alignment. - television and zsh git tests: disable tag signing in temporary repos. - fish-sk-git: stub xdg-open, the opener used on Linux. - zsh tests and docs: follow the 90_sk-git.sh -> sk-git.sh and 99_skim.sh -> skim.sh renames; drop the guard for fzf.sh.tmpl, which was intentionally removed in the fzf-git -> sk-git migration. - Mark all test scripts executable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Install zsh, shellcheck, shfmt, and pinned fish 4 / jj releases, then run every test under tests/ with grouped logs and per-test error annotations. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GitHub runners export CI=true, which makes templates skip CI-gated work (standalone tools, casks). The render-scripts and script-behavior tests set CI explicitly for the cases that need it, so unset any inherited value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chianyungcode
force-pushed
the
ci/split-fast-checks-e2e
branch
from
November 3, 2026 16:00
0e13b7f to
ccbae77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI took ~13 min per PR, and every macOS run since 2026-10-16 had failed.
chezmoi apply, which installs ~100 Homebrew formulae on macOS (~13 min) and apt packages on Ubuntu (~3.5 min). It ran on every PR, even theme or keybinding changes.herdr-plusisn't a Homebrew formula. It's already installed as a herdr plugin viacli-tool-setup.toml.Changes
ci.yamlruns on every PR and push tomain, on Ubuntu only:tests/suite (16 tests), with zsh, shellcheck and shfmt from apt plus pinned fish 4 and jj releases.tests/chezmoi-package-names.sh: checks every Homebrew formula and cask against the formulae.brew.sh API, every tap entry against its GitHub repo, and every APT package against the apt cache, without installing anything.e2e.yamlruns a realchezmoi applyon Ubuntu and macOS. It runs only on pushes tomainthat touch install logic, weekly (Mon 02:17 UTC) to catch upstream package drift, or manually withgh workflow run e2e.yaml --ref <branch>.automated_test.yaml.herdr-plusformula fromhomebrew.toml.Fixed tests
All existing tests were broken or never ran in CI. Every one still guards real behavior, so none were deleted.
chezmoi-render-scripts.sh,chezmoi-script-behavior.sh: read the machine's own chezmoi config, so.xdgwas missing anywhere but the author's laptop. They now generate a config.chezmoi-render-scripts.sh,chezmoi-script-behavior.sh: also picked up the runner'sCI=true, which makes templates skip CI-gated work. They now unset it and setCIonly for the cases that test CI behavior.chezmoi-script-behavior.sh: assumed every imperative tool was disabled. It now checks that the real data renders exactly its enabled entries. It also addedgzipto a restrictedPATH, since GNU tar needs it on Linux.television-git-channels.sh: exact-string checks broke after taplo aligned the=signs. Key/value checks now ignore whitespace.tag.gpgsign=truebrokegit tagin temporary repos. Signing is now disabled there.fish-sk-git.sh: stubbed only macOSopen, not Linuxxdg-open.docs/06-cli-integrations.md: updated for the90_sk-git.sh→sk-git.shand99_skim.sh→skim.shrenames. Dropped a guard forfzf.sh.tmpl, which the fzf-git → sk-git migration removed on purpose.b37d3406):sk-git.shnever deferred its Ctrl-G keybindings until after deferred antidote plugins, although its test expected that from day one. It now useszsh-defer, likeskim.shandzoxide.sh.Testing
ubuntu:24.04container with and withoutCI=true.chezmoi-package-names.shpassed on this PR's first CI run, including the APT check on the real Ubuntu runner.actionlint, including shellcheck on therun:blocks.🤖 Generated with Claude Code